<div dir="ltr">This didn't actually fix the Windows bots. The test should be fixed in r312747. You can use the 'not' utility to test for non-zero exit codes instead of subshells.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 7, 2017 at 12:10 PM, Keith Wyss via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kpw<br>
Date: Thu Sep  7 12:10:34 2017<br>
New Revision: 312739<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=312739&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=312739&view=rev</a><br>
Log:<br>
[XRay][tools] Disable windows for tests that use an unsupported shell redirect.<br>
<br>
The tests are filechecking against stderr and use some magic to make stdout go<br>
away and pipe stderr to FileCheck. This broke bots on windows.<br>
<br>
Modified:<br>
    llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-empty-case.yaml<br>
    llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-keep-going.yaml<br>
<br>
Modified: llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-empty-case.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-xray/X86/stack-empty-case.yaml?rev=312739&r1=312738&r2=312739&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-xray/X86/stack-empty-<wbr>case.yaml?rev=312739&r1=<wbr>312738&r2=312739&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-empty-case.yaml (original)<br>
+++ llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-empty-case.yaml Thu Sep  7 12:10:34 2017<br>
@@ -1,3 +1,8 @@<br>
+# The redirects used in the commands to FileCheck against stderr cannot be used<br>
+# with a windows test.<br>
+#<br>
+# UNSUPPORTED: windows<br>
+<br>
 #RUN: (llvm-xray stack %s 2>&1 || echo "Checking Command Failed") | FileCheck %s<br>
 ---<br>
 header:<br>
<br>
Modified: llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-keep-going.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-xray/X86/stack-keep-going.yaml?rev=312739&r1=312738&r2=312739&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-xray/X86/stack-keep-<wbr>going.yaml?rev=312739&r1=<wbr>312738&r2=312739&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-keep-going.yaml (original)<br>
+++ llvm/trunk/test/tools/llvm-<wbr>xray/X86/stack-keep-going.yaml Thu Sep  7 12:10:34 2017<br>
@@ -1,3 +1,8 @@<br>
+# The redirects used in the commands to FileCheck against stderr cannot be used<br>
+# with a windows test.<br>
+#<br>
+# UNSUPPORTED: windows<br>
+<br>
 #RUN: (llvm-xray stack %s 2>&1 1>&- || echo "Check Command Failed") | FileCheck --check-prefix HALT %s<br>
 #RUN: (llvm-xray stack -k %s 2>&1 && echo "Check Command Succeeded") | FileCheck --check-prefix KEEP-GOING-SUCCEEDS %s<br>
 #RUN: llvm-xray stack -k %s | FileCheck --check-prefix KEEP-GOING %s<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>