<div dir="ltr">Should this be report_fatal_error?</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 4, 2017 at 1:56 PM Davide Italiano via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">davide added a comment.<br>
<br>
I don't think we want to do something fancier, at least for now.<br>
If you run out of memory, we just report instead of crashing.<br>
Presumably, if something shows up, we can have an API that propagates back errors to the caller which can take an appropriate action, but I don't see a compelling use case (maybe I miss one?)<br>
<br>
<br>
<br>
================<br>
Comment at: lib/Object/Decompressor.cpp:98-100<br>
+  errs() << "Decompression failed: unable to allocate "<br>
+         << *static_cast<uint64_t *>(SizePtr) << " bytes.\n";<br>
+  exit(1);<br>
----------------<br>
fatal?<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D37447" rel="noreferrer" target="_blank">https://reviews.llvm.org/D37447</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>