<div dir="ltr">if it seems practical/reasonable - wouldn't bend over backwards, etc. But setting some precedent for unit tests here seems like it could be handy.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 4, 2017 at 10:38 AM Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I hit this issue in D37286 where depending on the types, some of the patterns start with a unnecessary bitconvert that SimplfiyTree is trying to skip over. So it is currently being tested by the x86 backend.<div><br></div><div>I can try to write a unit test if you want. I've not really looked much at our existing TableGen tests before.</div></div><div class="gmail_extra"></div><div class="gmail_extra"><br clear="all"><div><div class="m_-3600667974955981676gmail_signature" data-smartmail="gmail_signature">~Craig</div></div></div><div class="gmail_extra">
<br><div class="gmail_quote">On Mon, Sep 4, 2017 at 10:22 AM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">No chance of a test case for this, I take it?</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 29, 2017 at 7:06 PM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Tue Aug 29 19:05:03 2017<br>
New Revision: 312088<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=312088&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=312088&view=rev</a><br>
Log:<br>
[TableGen] Fix a range based for loop to take the value by reference so that SimplifyTree can modify the copy in the array if its needs to.<br>
<br>
Modified:<br>
    llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp<br>
<br>
Modified: llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp?rev=312088&r1=312087&r2=312088&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp?rev=312088&r1=312087&r2=312088&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp (original)<br>
+++ llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp Tue Aug 29 19:05:03 2017<br>
@@ -2304,7 +2304,7 @@ InferAllTypes(const StringMap<SmallVecto<br>
   bool MadeChange = true;<br>
   while (MadeChange) {<br>
     MadeChange = false;<br>
-    for (TreePatternNode *Tree : Trees) {<br>
+    for (TreePatternNode *&Tree : Trees) {<br>
       MadeChange |= Tree->ApplyTypeConstraints(*this, false);<br>
       MadeChange |= SimplifyTree(Tree);<br>
     }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></blockquote></div>