<div dir="ltr">Sounds like you fixed this in r312272, let me know if I need to poke this agian.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 31, 2017 at 12:50 PM, Matthias Braun <span dir="ltr"><<a href="mailto:mbraun@apple.com" target="_blank">mbraun@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>I think this broke a bunch of lnt tests:</div><div><br></div><div><a href="http://lab.llvm.org:8080/green/job/LNT_Tests/700/" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/LNT_Tests/700/</a></div><div><br></div><div>(you may have missed it because the V4Pages.py test was already broken before this commit).</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>- Matthias</div></font></span><div><div class="h5"><br><div><blockquote type="cite"><div>On Aug 31, 2017, at 10:07 AM, Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="m_6457081921100724217Apple-interchange-newline"><div><div>Author: rnk<br>Date: Thu Aug 31 10:07:35 2017<br>New Revision: 312254<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=312254&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=312254&view=rev</a><br>Log:<br>[lit] Make symlinks in test paths work a different way<br><br>Use os.path.normpath instead of realpath to collapse '..' and '.' path<br>components. Use realpath when caching search results about a path for<br>good measure.<br><br>I considered rigging up a test involving symlinks for this, but I doubt<br>I can check a symlink into SVN. The test would have to conditionally<br>create a symlink at runtime if the host OS supports it. This sounds too<br>fragile and complicated to me to be worth it.<br><br>Modified:<br>    llvm/trunk/utils/lit/lit/<wbr>discovery.py<br><br>Modified: llvm/trunk/utils/lit/lit/<wbr>discovery.py<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=312254&r1=312253&r2=312254&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/utils/lit/<wbr>lit/discovery.py?rev=312254&<wbr>r1=312253&r2=312254&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- llvm/trunk/utils/lit/lit/<wbr>discovery.py (original)<br>+++ llvm/trunk/utils/lit/lit/<wbr>discovery.py Thu Aug 31 10:07:35 2017<br>@@ -52,13 +52,14 @@ def getTestSuite(item, litConfig, cache)<br><br>     def search(path):<br>         # Check for an already instantiated test suite.<br>-        res = cache.get(path)<br>+        real_path = os.path.realpath(path)<br>+        res = cache.get(real_path)<br>         if res is None:<br>-            cache[path] = res = search1(path)<br>+            cache[real_path] = res = search1(path)<br>         return res<br><br>     # Canonicalize the path.<br>-    item = os.path.realpath(item)<br>+    item = os.path.normpath(item)<br><br>     # Skip files and virtual components.<br>     components = []<br><br><br>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br></div></div></blockquote></div><br></div></div></div></blockquote></div><br></div>