<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">I think this broke a bunch of lnt tests:</div><div class=""><br class=""></div><div class=""><a href="http://lab.llvm.org:8080/green/job/LNT_Tests/700/" class="">http://lab.llvm.org:8080/green/job/LNT_Tests/700/</a></div><div class=""><br class=""></div><div class="">(you may have missed it because the V4Pages.py test was already broken before this commit).</div><div class=""><br class=""></div><div class="">- Matthias</div><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 31, 2017, at 10:07 AM, Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: rnk<br class="">Date: Thu Aug 31 10:07:35 2017<br class="">New Revision: 312254<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=312254&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=312254&view=rev</a><br class="">Log:<br class="">[lit] Make symlinks in test paths work a different way<br class=""><br class="">Use os.path.normpath instead of realpath to collapse '..' and '.' path<br class="">components. Use realpath when caching search results about a path for<br class="">good measure.<br class=""><br class="">I considered rigging up a test involving symlinks for this, but I doubt<br class="">I can check a symlink into SVN. The test would have to conditionally<br class="">create a symlink at runtime if the host OS supports it. This sounds too<br class="">fragile and complicated to me to be worth it.<br class=""><br class="">Modified:<br class=""> llvm/trunk/utils/lit/lit/discovery.py<br class=""><br class="">Modified: llvm/trunk/utils/lit/lit/discovery.py<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=312254&r1=312253&r2=312254&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=312254&r1=312253&r2=312254&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/utils/lit/lit/discovery.py (original)<br class="">+++ llvm/trunk/utils/lit/lit/discovery.py Thu Aug 31 10:07:35 2017<br class="">@@ -52,13 +52,14 @@ def getTestSuite(item, litConfig, cache)<br class=""><br class=""> def search(path):<br class=""> # Check for an already instantiated test suite.<br class="">- res = cache.get(path)<br class="">+ real_path = os.path.realpath(path)<br class="">+ res = cache.get(real_path)<br class=""> if res is None:<br class="">- cache[path] = res = search1(path)<br class="">+ cache[real_path] = res = search1(path)<br class=""> return res<br class=""><br class=""> # Canonicalize the path.<br class="">- item = os.path.realpath(item)<br class="">+ item = os.path.normpath(item)<br class=""><br class=""> # Skip files and virtual components.<br class=""> components = []<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></body></html>