<div dir="ltr">Yup. Make this linux-only then for now (as opposed to not-Mac)</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 29, 2017 at 3:05 PM, Matt Morehouse <span dir="ltr"><<a href="mailto:mascasa@google.com" target="_blank">mascasa@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">1) Windows build. Apparently the tls_model attribute doesn't work there...<div>2) check-asan (below)</div><div><br></div><div><span style="color:rgb(0,0,0);font-family:"Courier New",courier,monotype,monospace;font-size:medium">FAIL: AddressSanitizer-x86_64-linux :: TestCases/Linux/interface_<wbr>symbols_linux.c (920 of 1294)</span></div><pre style="font-family:"Courier New",courier,monotype,monospace;color:rgb(0,0,0);font-size:medium"><span class="m_9059745197154888174gmail-stdout">******************** TEST 'AddressSanitizer-x86_64-linux :: TestCases/Linux/interface_<wbr>symbols_linux.c' FAILED ********************
Script:
--
/mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/./bin/clang -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -O2 /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/projects/compiler-rt/<wbr>test/asan/TestCases/Linux/<wbr>interface_symbols_linux.c -o /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>exe
nm -D /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>exe | grep " [TWw] " | grep -o "\(__asan_\|__ubsan_\|__<wbr>sancov_\|__sanitizer_\)[^ ]*" | grep -v "__s</span><span class="m_9059745197154888174gmail-stdout">anitizer_syscall" | grep -v "__sanitizer_weak_hook" | grep -v "__ubsan_handle_dynamic_type_<wbr>cache_miss" | sed -e "s/__asan_version_mismatch_<wbr>check_v[0-9]+/__asan_version_<wbr>mismatch_check/" > /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>exports
</span><span class="m_9059745197154888174gmail-stdout">grep -e "INTERFACE_\(WEAK_\)\?<wbr>FUNCTION" /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/projects/compiler-rt/<wbr>test/asan/TestCases/Linux/../.<wbr>./../../lib/asan/asan_<wbr>interface.inc /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/projects/compiler-rt/<wbr>test/asan/TestCases/Linux/../.<wbr>./../../lib/ubsan/ubsan_<wbr>interface.inc /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/projects/compiler-rt/<wbr>test/asan/TestCases/Linux/../.<wbr>./../../lib/sanitizer_common/<wbr>sanitizer_common_interface.inc /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/projects/compiler-rt/<wbr>test/asan/TestCases/Linux/../.<wbr>./../../lib/sanitizer_common/<wbr>sanitizer_common_interface_<wbr>posix.inc /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/projects/compiler-rt/<wbr>test/asan/TestCases/Linux/../.<wbr>./../../lib/sanitizer_common/<wbr>sanitizer_coverage_interface.<wbr>inc | grep -v "__sanitizer_weak_hook" | sed -e "s/.*(//" -e "s/).*//" > /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>imports
cat /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>imports | sort | uniq > /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>imports-sorted
cat /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>exports | sort | uniq > /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>exports-sorted
echo
echo "=== NOTE === If you see a mismatch below, please update sanitizer_interface.inc files."
diff /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>imports-sorted /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm_build64/tools/clang/<wbr>runtime/compiler-rt-bins/test/<wbr>asan/X86_64LinuxConfig/<wbr>TestCases/Linux/Output/<wbr>interface_symbols_linux.c.tmp.<wbr>exports-sorted
--
Exit Code: 1
Command Output (stdout):
--
=== NOTE === If you see a mismatch below, please update sanitizer_interface.inc files.
149a150
> __sancov_lowest_stack</span></pre></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 29, 2017 at 3:01 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What broke? </div><div class="m_9059745197154888174HOEnZb"><div class="m_9059745197154888174h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 29, 2017 at 2:56 PM, Matt Morehouse via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: morehouse<br>
Date: Tue Aug 29 14:56:56 2017<br>
New Revision: 312047<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=312047&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=312047&view=rev</a><br>
Log:<br>
Revert "[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer"<br>
<br>
This reverts r312026 due to bot breakage.<br>
<br>
Modified:<br>
compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_coverage_li<wbr>bcdep_new.cc<br>
compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_internal_de<wbr>fs.h<br>
compiler-rt/trunk/test/fuzzer/<wbr>deep-recursion.test<br>
<br>
Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_coverage_li<wbr>bcdep_new.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc?rev=312047&r1=312046&r2=312047&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/sanitizer_cover<wbr>age_libcdep_new.cc?rev=312047&<wbr>r1=312046&r2=312047&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_coverage_li<wbr>bcdep_new.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_coverage_li<wbr>bcdep_new.cc Tue Aug 29 14:56:56 2017<br>
@@ -211,10 +211,5 @@ SANITIZER_INTERFACE_WEAK_DEF(v<wbr>oid, __san<br>
SANITIZER_INTERFACE_WEAK_DEF(<wbr>void, __sanitizer_cov_8bit_counters_<wbr>init, void) {}<br>
SANITIZER_INTERFACE_WEAK_DEF(<wbr>void, __sanitizer_cov_pcs_init, void) {}<br>
} // extern "C"<br>
-// Weak definition for code instrumented with -fsanitize-coverage=stack-dept<wbr>h<br>
-// and later linked with code containing a strong definition.<br>
-// E.g., -fsanitize=fuzzer-no-link<br>
-SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE<br>
-SANITIZER_TLS_INITIAL_EXEC_AT<wbr>TRIBUTE uptr __sancov_lowest_stack;<br>
<br>
#endif // !SANITIZER_FUCHSIA<br>
<br>
Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_internal_de<wbr>fs.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h?rev=312047&r1=312046&r2=312047&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/sanitizer_inter<wbr>nal_defs.h?rev=312047&r1=31204<wbr>6&r2=312047&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_internal_de<wbr>fs.h (original)<br>
+++ compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_internal_de<wbr>fs.h Tue Aug 29 14:56:56 2017<br>
@@ -35,14 +35,6 @@<br>
# define SANITIZER_WEAK_ATTRIBUTE __attribute__((weak))<br>
#endif<br>
<br>
-// Mac handles TLS differently<br>
-#if SANITIZER_MAC<br>
-# define SANITIZER_TLS_INITIAL_EXEC_ATT<wbr>RIBUTE<br>
-#else<br>
-# define SANITIZER_TLS_INITIAL_EXEC_ATT<wbr>RIBUTE \<br>
- __attribute__((tls_model("init<wbr>ial-exec"))) thread_local<br>
-#endif<br>
-<br>
//--------------------------- WEAK FUNCTIONS ------------------------------<wbr>---//<br>
// When working with weak functions, to simplify the code and make it more<br>
// portable, when possible define a default implementation using this macro:<br>
<br>
Modified: compiler-rt/trunk/test/fuzzer/<wbr>deep-recursion.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/fuzzer/deep-recursion.test?rev=312047&r1=312046&r2=312047&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/test/f<wbr>uzzer/deep-recursion.test?rev=<wbr>312047&r1=312046&r2=312047&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/test/fuzzer/<wbr>deep-recursion.test (original)<br>
+++ compiler-rt/trunk/test/fuzzer/<wbr>deep-recursion.test Tue Aug 29 14:56:56 2017<br>
@@ -1,5 +1,5 @@<br>
# Test that we can find a stack overflow<br>
REQUIRES: linux<br>
-RUN: %cpp_compiler %S/DeepRecursionTest.cpp -o %t<br>
+RUN: %cpp_compiler -fsanitize-coverage=stack-dept<wbr>h %S/DeepRecursionTest.cpp -o %t<br>
RUN: not %t -seed=1 -runs=100000000 2>&1 | FileCheck %s<br>
CHECK: ERROR: libFuzzer: deadly signal<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>