<div dir="ltr">Perhaps the API could be refactored to return Expected<pair<DebugInfo*, StringRef>> ? </div><br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 15, 2017 at 2:47 PM Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Tue Aug 15 14:46:51 2017<br>
New Revision: 310965<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310965&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=310965&view=rev</a><br>
Log:<br>
Fix warning about unused variable.<br>
<br>
I'm explicitly ignoring the warning by casting to void instead of<br>
deleting the local assignment, because it's confusing to see a<br>
function that fails when its return value evaluates to true.<br>
But when you see that it's a std::error_code, it makes more sense.<br>
<br>
Modified:<br>
    lld/trunk/COFF/Writer.cpp<br>
<br>
Modified: lld/trunk/COFF/Writer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Writer.cpp?rev=310965&r1=310964&r2=310965&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Writer.cpp?rev=310965&r1=310964&r2=310965&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/COFF/Writer.cpp (original)<br>
+++ lld/trunk/COFF/Writer.cpp Tue Aug 15 14:46:51 2017<br>
@@ -268,8 +268,10 @@ static Optional<codeview::DebugInfo> loa<br>
<br>
     const codeview::DebugInfo *ExistingDI = nullptr;<br>
     StringRef PDBFileName;<br>
-    if (auto EC = File.getDebugPDBInfo(ExistingDI, PDBFileName))<br>
+    if (auto EC = File.getDebugPDBInfo(ExistingDI, PDBFileName)) {<br>
+      (void)EC;<br>
       return None;<br>
+    }<br>
     // We only support writing PDBs in v70 format.  So if this is not a build<br>
     // id that we recognize / support, ignore it.<br>
     if (ExistingDI->Signature.CVSignature != OMF::Signature::PDB70)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>