<div dir="ltr">Thanks!<div>Teresa</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 23, 2017 at 2:43 AM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Wed Aug 23 02:43:41 2017<br>
New Revision: 311541<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=311541&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=311541&view=rev</a><br>
Log:<br>
[gold] Test we don't strip globals when producing relocatables.<br>
<br>
lld was broken in this regard (PR33097). The gold plugin gets this<br>
right so, no changes needed, but better adding a test.<br>
<br>
Added:<br>
    llvm/trunk/test/tools/gold/<wbr>X86/relocatable.ll<br>
<br>
Added: llvm/trunk/test/tools/gold/<wbr>X86/relocatable.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/relocatable.ll?rev=311541&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>gold/X86/relocatable.ll?rev=<wbr>311541&view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/gold/<wbr>X86/relocatable.ll (added)<br>
+++ llvm/trunk/test/tools/gold/<wbr>X86/relocatable.ll Wed Aug 23 02:43:41 2017<br>
@@ -0,0 +1,26 @@<br>
+; RUN: llvm-as %s -o %t1.o<br>
+; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \<br>
+; RUN:    -r %t1.o -o %t<br>
+; RUN: llvm-readobj -symbols %t | FileCheck %s<br>
+<br>
+; CHECK: Symbol {<br>
+; CHECK:   Name: foo<br>
+; CHECK-NEXT:   Value: 0x0<br>
+; CHECK-NEXT:   Size: 1<br>
+; CHECK-NEXT:   Binding: Global<br>
+; CHECK-NEXT:   Type: Function<br>
+; CHECK-NEXT:   Other: 0<br>
+; CHECK-NEXT:   Section: .text.foo<br>
+; CHECK-NEXT: }<br>
+<br>
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:<wbr>32:64-S128"<br>
+target triple = "x86_64-unknown-linux-gnu"<br>
+<br>
+define void @foo() {<br>
+  call void @bar()<br>
+  ret void<br>
+}<br>
+<br>
+define internal void @bar() {<br>
+  ret void<br>
+}<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div>