<div dir="ltr">Hans, can we merge this to 5.0? It looks like it was missed in r286342 which fixed PR30947 back in November 2016.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Sat, Aug 19, 2017 at 3:02 PM, Craig Topper via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Sat Aug 19 15:02:02 2017<br>
New Revision: 311263<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=311263&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=311263&view=rev</a><br>
Log:<br>
[AVX512] Use alignedstore256 in a pattern that's emitting a 256-bit movaps from an extract subvector operation.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/<wbr>X86InstrAVX512.td<br>
    llvm/trunk/test/CodeGen/X86/<wbr>avx512-extract-subvector.ll<br>
<br>
Modified: llvm/trunk/lib/Target/X86/<wbr>X86InstrAVX512.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrAVX512.td?rev=311263&r1=311262&r2=311263&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>X86/X86InstrAVX512.td?rev=<wbr>311263&r1=311262&r2=311263&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/X86/<wbr>X86InstrAVX512.td (original)<br>
+++ llvm/trunk/lib/Target/X86/<wbr>X86InstrAVX512.td Sat Aug 19 15:02:02 2017<br>
@@ -3721,8 +3721,8 @@ let Predicates = [HasVLX] in {<br>
   def : Pat<(alignedstore256 (v4f64 (extract_subvector<br>
                                      (v8f64 VR512:$src), (iPTR 0))), addr:$dst),<br>
      (VMOVAPDZ256mr addr:$dst, (v4f64 (EXTRACT_SUBREG VR512:$src,sub_ymm)))>;<br>
-  def : Pat<(alignedstore (v8f32 (extract_subvector<br>
-                                  (v16f32 VR512:$src), (iPTR 0))), addr:$dst),<br>
+  def : Pat<(alignedstore256 (v8f32 (extract_subvector<br>
+                                     (v16f32 VR512:$src), (iPTR 0))), addr:$dst),<br>
      (VMOVAPSZ256mr addr:$dst, (v8f32 (EXTRACT_SUBREG VR512:$src,sub_ymm)))>;<br>
   def : Pat<(alignedstore256 (v4i64 (extract_subvector<br>
                                      (v8i64 VR512:$src), (iPTR 0))), addr:$dst),<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/<wbr>avx512-extract-subvector.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx512-extract-subvector.ll?rev=311263&r1=311262&r2=311263&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>CodeGen/X86/avx512-extract-<wbr>subvector.ll?rev=311263&r1=<wbr>311262&r2=311263&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/CodeGen/X86/<wbr>avx512-extract-subvector.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/<wbr>avx512-extract-subvector.ll Sat Aug 19 15:02:02 2017<br>
@@ -493,7 +493,7 @@ entry:<br>
 define void @extract_subvector512_v8f32_<wbr>store_lo_align_16(float* nocapture %addr, <16 x float> %a) nounwind uwtable ssp {<br>
 ; SKX-LABEL: extract_subvector512_v8f32_<wbr>store_lo_align_16:<br>
 ; SKX:       ## BB#0: ## %entry<br>
-; SKX-NEXT:    vmovaps %ymm0, (%rdi)<br>
+; SKX-NEXT:    vmovups %ymm0, (%rdi)<br>
 ; SKX-NEXT:    vzeroupper<br>
 ; SKX-NEXT:    retq<br>
 entry:<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>