<div dir="ltr">Yea that's not a bad idea, thanks for the suggestion.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Aug 17, 2017 at 3:33 PM Justin Bogner <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> writes:<br>
> Author: zturner<br>
> Date: Thu Aug 17 15:20:15 2017<br>
> New Revision: 311129<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=311129&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=311129&view=rev</a><br>
> Log:<br>
> Fix warning about covered switch default.<br>
<br>
I feel like removing the default and returning "Unknown Symbol..."<br>
instead of (the unreachable) `return ""` after the switch would be<br>
slightly clearer.<br>
<br>
> Modified:<br>
>     llvm/trunk/tools/llvm-pdbutil/MinimalSymbolDumper.cpp<br>
><br>
> Modified: llvm/trunk/tools/llvm-pdbutil/MinimalSymbolDumper.cpp<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/MinimalSymbolDumper.cpp?rev=311129&r1=311128&r2=311129&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/MinimalSymbolDumper.cpp?rev=311129&r1=311128&r2=311129&view=diff</a><br>
> ==============================================================================<br>
><br>
> --- llvm/trunk/tools/llvm-pdbutil/MinimalSymbolDumper.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-pdbutil/MinimalSymbolDumper.cpp Thu Aug 17 15:20:15 2017<br>
> @@ -25,7 +25,7 @@ using namespace llvm::codeview;<br>
>  using namespace llvm::pdb;<br>
><br>
>  static std::string getSymbolKindName(SymbolKind K) {<br>
> -  switch (K) {<br>
> +  switch (uint32_t(K)) {<br>
>  #define SYMBOL_RECORD(EnumName, value, name)                                   \<br>
>    case EnumName:                                                               \<br>
>      return #EnumName;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>