<div dir="ltr"><div><div><div>It is a newly introduced warning: <a href="https://reviews.llvm.org/D36526">https://reviews.llvm.org/D36526</a><br><br></div>It warns when two different types of (non-anonymous) enums are used in the same switch. An alternative fix would be to make AMDGPU::fixup_si_sopp_br part of an anonymous enum instead. Feel free to change it, the main purpose of this commit was to unbreak a build bot which treats warnings as errors. I also sent a mail to the one who committed this code, to change this fix if desired.<br><br></div>Regards,<br></div>Gábor <br></div><div class="gmail_extra"><br><div class="gmail_quote">On 14 August 2017 at 22:39, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Which warning is being suppressed? If it's a -Wswitch-enum - why not remove the default? (& place the unreachable after the switch)</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 9, 2017 at 3:39 AM Gabor Horvath via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: xazax<br>
Date: Wed Aug  9 03:38:53 2017<br>
New Revision: 310459<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310459&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=310459&view=rev</a><br>
Log:<br>
Suppress a warning. NFC.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/AMDGPU/<wbr>MCTargetDesc/AMDGPUAsmBackend.<wbr>cpp<br>
<br>
Modified: llvm/trunk/lib/Target/AMDGPU/<wbr>MCTargetDesc/AMDGPUAsmBackend.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp?rev=310459&r1=310458&r2=310459&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>AMDGPU/MCTargetDesc/<wbr>AMDGPUAsmBackend.cpp?rev=<wbr>310459&r1=310458&r2=310459&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/AMDGPU/<wbr>MCTargetDesc/AMDGPUAsmBackend.<wbr>cpp (original)<br>
+++ llvm/trunk/lib/Target/AMDGPU/<wbr>MCTargetDesc/AMDGPUAsmBackend.<wbr>cpp Wed Aug  9 03:38:53 2017<br>
@@ -78,7 +78,7 @@ static uint64_t adjustFixupValue(const M<br>
                                  MCContext *Ctx) {<br>
   int64_t SignedValue = static_cast<int64_t>(Value);<br>
<br>
-  switch (Fixup.getKind()) {<br>
+  switch (static_cast<unsigned>(Fixup.<wbr>getKind())) {<br>
   case AMDGPU::fixup_si_sopp_br: {<br>
     int64_t BrImm = (SignedValue - 4) / 4;<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div><br></div>