<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 14 August 2017 at 16:40, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><span class=""><br><blockquote type="cite"><div>On Aug 14, 2017, at 08:39, Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:</div><br class="m_477781492940481018Apple-interchange-newline"><div><br class="m_477781492940481018Apple-interchange-newline"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">On 14 August 2017 at 16:19, Duncan P. N. Exon Smith via llvm-commits<span class="m_477781492940481018Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@<wbr>lists.llvm.org</a>></span><span class="m_477781492940481018Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Should this be part of -Wextra?<br></blockquote><div><br></div><div>Do you mean the flag itself or LLVM's compilation?</div></div></div></blockquote><div><br></div></span><div>I meant the flag itself.</div></div></div></blockquote><div><br></div><div>FWIW it doesn't look like GCC puts it in -Wextra. Not sure if Clang should or not though.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><span class=""><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div>LLVM doesn't use -Wextra right now AFAIK.</div></div></div></blockquote><div><br></div></span><div>Oh, interesting.</div><span class=""><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div><div class="m_477781492940481018h5"><br>> On Aug 14, 2017, at 04:13, Alex Lorenz via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br>><br>> arphaman created this revision.<br>> Herald added a subscriber: mgorny.<br>><br>> Clang 5 supports -Wstrict-prototypes. We should use it to catch any C declarations that declare a non-prototype function.<br>><br>><br>> Repository:<br>>  rL LLVM<br>><br>><span class="m_477781492940481018Apple-converted-space"> </span><a href="https://reviews.llvm.org/D36669" rel="noreferrer" target="_blank">https://reviews.llvm.org/D36<wbr>669</a><br>><br>> Files:<br>>  cmake/modules/HandleLLVMOption<wbr>s.cmake<br>>  projects/compiler-rt/lib/profi<wbr>le/GCDAProfiling.c<br>>  projects/compiler-rt/lib/profi<wbr>le/InstrProfiling.h<br>>  projects/compiler-rt/lib/profi<wbr>le/InstrProfilingFile.c<br>>  projects/compiler-rt/lib/profi<wbr>le/InstrProfilingInternal.h<br>>  projects/compiler-rt/lib/profi<wbr>le/InstrProfilingUtil.h<br>>  projects/libunwind/src/config.<wbr>h<br>>  projects/libunwind/src/unwind_<wbr>ext.h<br>><br></div></div>> <D36669.110939.patch><br><br>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></span></div><br></div></blockquote></div><br></div></div>