<div dir="ltr">I'll second that, especially I'm familiar with languages in which all free variables automatically capture outer local variables.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 14, 2017 at 1:21 PM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Generally for non-escaped lambdas I'd encourage the use of [&] - no need to maintain a list of specific captures & other nested scopes (if, while, etc) 'capture' all locals implicitly anyway, so this shouldn't be much/any different.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 11, 2017 at 1:38 PM Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Fri Aug 11 13:37:49 2017<br>
New Revision: 310752<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310752&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=310752&view=rev</a><br>
Log:<br>
Remove unused lambda capture.<br>
<br>
Modified:<br>
    lld/trunk/COFF/PDB.cpp<br>
<br>
Modified: lld/trunk/COFF/PDB.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/PDB.cpp?rev=310752&r1=310751&r2=310752&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/COFF/PDB.<wbr>cpp?rev=310752&r1=310751&r2=<wbr>310752&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/COFF/PDB.cpp (original)<br>
+++ lld/trunk/COFF/PDB.cpp Fri Aug 11 13:37:49 2017<br>
@@ -709,7 +709,7 @@ void PDBLinker::addObjectsToPDB() {<br>
   // Compute the public and global symbols.<br>
   auto &GsiBuilder = Builder.getGsiBuilder();<br>
   std::vector<PublicSym32> Publics;<br>
-  Symtab->forEachSymbol([&<wbr>Publics, &GsiBuilder](Symbol *S) {<br>
+  Symtab->forEachSymbol([&<wbr>Publics](Symbol *S) {<br>
     // Only emit defined, live symbols that have a chunk.<br>
     auto *Def = dyn_cast<Defined>(S->body());<br>
     if (Def && Def->isLive() && Def->getChunk())<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div><br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>