<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 14, 2017, at 08:39, Alex L <<a href="mailto:arphaman@gmail.com" class="">arphaman@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On 14 August 2017 at 16:19, Duncan P. N. Exon Smith via llvm-commits<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">Should this be part of -Wextra?<br class=""></blockquote><div class=""><br class=""></div><div class="">Do you mean the flag itself or LLVM's compilation?</div></div></div></blockquote><div><br class=""></div><div>I meant the flag itself.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="">LLVM doesn't use -Wextra right now AFAIK.</div></div></div></blockquote><div><br class=""></div><div>Oh, interesting.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class=""><div class="h5"><br class="">> On Aug 14, 2017, at 04:13, Alex Lorenz via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class="">><br class="">> arphaman created this revision.<br class="">> Herald added a subscriber: mgorny.<br class="">><br class="">> Clang 5 supports -Wstrict-prototypes. We should use it to catch any C declarations that declare a non-prototype function.<br class="">><br class="">><br class="">> Repository:<br class="">>  rL LLVM<br class="">><br class="">><span class="Apple-converted-space"> </span><a href="https://reviews.llvm.org/D36669" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D36669</a><br class="">><br class="">> Files:<br class="">>  cmake/modules/<wbr class="">HandleLLVMOptions.cmake<br class="">>  projects/compiler-rt/lib/<wbr class="">profile/GCDAProfiling.c<br class="">>  projects/compiler-rt/lib/<wbr class="">profile/InstrProfiling.h<br class="">>  projects/compiler-rt/lib/<wbr class="">profile/InstrProfilingFile.c<br class="">>  projects/compiler-rt/lib/<wbr class="">profile/<wbr class="">InstrProfilingInternal.h<br class="">>  projects/compiler-rt/lib/<wbr class="">profile/InstrProfilingUtil.h<br class="">>  projects/libunwind/src/config.<wbr class="">h<br class="">>  projects/libunwind/src/unwind_<wbr class="">ext.h<br class="">><br class=""></div></div>> <D36669.110939.patch><br class=""><br class="">______________________________<wbr class="">_________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></div><br class=""></body></html>