<div dir="ltr">Maybe use 'cast' instead of 'dyn_cast' - then there's no need for the assert? (since it's built into 'cast')</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 9, 2017 at 3:48 AM Simon Dardis via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sdardis<br>
Date: Wed Aug  9 03:47:52 2017<br>
New Revision: 310460<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310460&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=310460&view=rev</a><br>
Log:<br>
[mips] PR34083 - Wimplicit-fallthrough warning in MipsAsmParser.cpp<br>
<br>
Assert that a binary expression is actually a binary expression,<br>
rather than potientially incorrectly attempting to handle it as a<br>
unary expression.<br>
<br>
This resolves PR34083.<br>
<br>
Thanks to Simonn Pilgrim for reporting the issue!<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp?rev=310460&r1=310459&r2=310460&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp?rev=310460&r1=310459&r2=310460&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp Wed Aug  9 03:47:52 2017<br>
@@ -5439,12 +5439,13 @@ bool MipsAsmParser::isEvaluated(const MC<br>
     return true;<br>
   case MCExpr::SymbolRef:<br>
     return (cast<MCSymbolRefExpr>(Expr)->getKind() != MCSymbolRefExpr::VK_None);<br>
-  case MCExpr::Binary:<br>
-    if (const MCBinaryExpr *BE = dyn_cast<MCBinaryExpr>(Expr)) {<br>
-      if (!isEvaluated(BE->getLHS()))<br>
-        return false;<br>
-      return isEvaluated(BE->getRHS());<br>
-    }<br>
+  case MCExpr::Binary: {<br>
+    const MCBinaryExpr *BE = dyn_cast<MCBinaryExpr>(Expr);<br>
+    assert(BE && "Binary expression is not a binary expression?");<br>
+    if (!isEvaluated(BE->getLHS()))<br>
+      return false;<br>
+    return isEvaluated(BE->getRHS());<br>
+  }<br>
   case MCExpr::Unary:<br>
     return isEvaluated(cast<MCUnaryExpr>(Expr)->getSubExpr());<br>
   case MCExpr::Target:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>