<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>> Ah, OK. I'm still curious about whether this results in a
      loss of test coverage. Without this test, would the bug it was
      testing still be caught by some test failure in at least one of
      the forward or reverse iteration modes?</p>
    <p>Sorry ... I missed that. Yes, the reverse iteration buildbot <span
        style="font-size:11.0pt;line-height:107%;
font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-fareast-font-family:
Calibri;mso-fareast-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;
        mso-bidi-font-family:"Times New
        Roman";mso-bidi-theme-font:minor-bidi;
mso-ansi-language:EN-US;mso-fareast-language:EN-US;mso-bidi-language:AR-SA"><a
          href="http://lab.llvm.org:8011/builders/reverse-iteration">http://lab.llvm.org:8011/builders/reverse-iteration</a>
      </span>would test these. These tests were a stopgap solution
      anyway while the reverse builtbot was being setup.<!--[if gte mso 9]><xml>
 <o:OfficeDocumentSettings>
  <o:AllowPNG/>
 </o:OfficeDocumentSettings>
</xml><![endif]--></p>
    <br>
    > I'll just do that (r310506 & r310508) - done! :)<br>
    Thanks!<br>
    <p><span style="font-size:11.0pt;line-height:107%;
font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-fareast-font-family:
Calibri;mso-fareast-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;
        mso-bidi-font-family:"Times New
        Roman";mso-bidi-theme-font:minor-bidi;
mso-ansi-language:EN-US;mso-fareast-language:EN-US;mso-bidi-language:AR-SA"><br>
      </span></p>
    <p><span style="font-size:11.0pt;line-height:107%;
font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-fareast-font-family:
Calibri;mso-fareast-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;
        mso-bidi-font-family:"Times New
        Roman";mso-bidi-theme-font:minor-bidi;
mso-ansi-language:EN-US;mso-fareast-language:EN-US;mso-bidi-language:AR-SA">--Mandeep<br>
      </span></p>
    <br>
    <div class="moz-cite-prefix">On 8/9/2017 11:35 AM, David Blaikie
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAENS6EuHc4Oh9eZmXg1bD5SDgmC7kCkfwJ7Rt0bAHOYn=8P5zQ@mail.gmail.com">
      <div dir="ltr"><br>
        <br>
        <div class="gmail_quote">
          <div dir="ltr">On Wed, Aug 9, 2017 at 1:44 AM Grang, Mandeep
            Singh <<a href="mailto:mgrang@codeaurora.org"
              moz-do-not-send="true">mgrang@codeaurora.org</a>>
            wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div> In D35043 I have removed the llvm tests which use
              -reverse-iterate. This patch removes the clang tests.<br>
            </div>
          </blockquote>
          <div><br>
            Ah, OK. I'm still curious about whether this results in a
            loss of test coverage. Without this test, would the bug it
            was testing still be caught by some test failure in at least
            one of the forward or reverse iteration modes?<br>
             </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div>Should I post a later patch to change all "class
              PointerLikeTypeTraits" to "struct PointerLikeTypeTraits"?</div>
          </blockquote>
          <div><br>
            I'll just do that (r310506 & r310508) - done! :)<br>
             </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div><br>
              <br>
              <div class="m_-544102029957928977moz-cite-prefix">On
                8/7/2017 2:50 PM, David Blaikie wrote:<br>
              </div>
              <blockquote type="cite">
                <div dir="ltr"><br>
                  <br>
                  <div class="gmail_quote">
                    <div dir="ltr">On Mon, Aug 7, 2017 at 12:08 PM
                      Mandeep Singh Grang via Phabricator <<a
                        href="mailto:reviews@reviews.llvm.org"
                        target="_blank" moz-do-not-send="true">reviews@reviews.llvm.org</a>>
                      wrote:<br>
                    </div>
                    <blockquote class="gmail_quote" style="margin:0 0 0
                      .8ex;border-left:1px #ccc solid;padding-left:1ex">mgrang
                      added a comment.<br>
                      <br>
                      This patch does 3 things:<br>
                      <br>
                      1. Get rid of the unit test <a
                        href="http://objc-modern-metadata-visibility2.mm"
                        rel="noreferrer" target="_blank"
                        moz-do-not-send="true">objc-modern-metadata-visibility2.mm</a>
                      because this test check uses flag
                      -reverse-iterate. This flag will be removed in <a
                        href="https://reviews.llvm.org/D35043"
                        rel="noreferrer" target="_blank"
                        moz-do-not-send="true">https://reviews.llvm.org/D35043</a>.<br>
                    </blockquote>
                    <div><br>
                      Sure - please commit that separately (probably
                      once D35043 is approved - probably best to include
                      that removal in D35043, or a separate patch that
                      /only/ removes the -reverse-iterate flag (&
                      any tests that use it) as a standalone change?).<br>
                      <br>
                      Does this test need a replacement? If this test is
                      removed and the underlying issue it was testing
                      regresses, will one of the buildbots (reverse or
                      normal) catch the problem?<br>
                       </div>
                    <blockquote class="gmail_quote" style="margin:0 0 0
                      .8ex;border-left:1px #ccc solid;padding-left:1ex">2.
                      <a href="https://reviews.llvm.org/D35043"
                        rel="noreferrer" target="_blank"
                        moz-do-not-send="true">https://reviews.llvm.org/D35043</a>
                      gets rid of the empty base definition for
                      PointerLikeTypeTraits. This results in a compiler
                      warning because PointerLikeTypeTrait has been
                      defined as struct here while in the header it is a
                      class. So I have changed struct to class.<br>
                    </blockquote>
                    <div><br>
                      I'd probably go the other way - traits classes
                      like this make more sense as structs, I think - it
                      only has public members & no implementation
                      really has any need for supporting private
                      members.<br>
                       </div>
                    <blockquote class="gmail_quote" style="margin:0 0 0
                      .8ex;border-left:1px #ccc solid;padding-left:1ex">3.
                      Since I changed struct PointerLikeTypeTrait to
                      class PointerLikeTypeTrait here, the member
                      functions are no longer public now. This results
                      in a compiler error. So I explicitly marked them
                      as public here.<br>
                      <br>
                      <br>
                      <a href="https://reviews.llvm.org/D36386"
                        rel="noreferrer" target="_blank"
                        moz-do-not-send="true">https://reviews.llvm.org/D36386</a><br>
                      <br>
                      <br>
                      <br>
                    </blockquote>
                  </div>
                </div>
              </blockquote>
              <br>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>