<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 8 August 2017 at 13:41, Nemanja Ivanovic via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nemanjai<br>
Date: Tue Aug  8 05:41:56 2017<br>
New Revision: 310356<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310356&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=310356&view=rev</a><br>
Log:<br>
Appease compilers that have the -Wcovered-switch-default switch.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/PowerPC/<wbr>PPCISelDAGToDAG.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/PowerPC/<wbr>PPCISelDAGToDAG.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp?rev=310356&r1=310355&r2=310356&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>PowerPC/PPCISelDAGToDAG.cpp?<wbr>rev=310356&r1=310355&r2=<wbr>310356&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/PowerPC/<wbr>PPCISelDAGToDAG.cpp (original)<br>
+++ llvm/trunk/lib/Target/PowerPC/<wbr>PPCISelDAGToDAG.cpp Tue Aug  8 05:41:56 2017<br>
@@ -2814,7 +2814,6 @@ SDValue PPCDAGToDAGISel::<wbr>getCompoundZero<br>
<br>
   // Produce the value that needs to be either zero or sign extended.<br>
   switch (CmpTy) {<br>
-  default: llvm_unreachable("Unknown Zero-comparison type.");<br>
   case ZeroCompare::GEZExt:<br>
   case ZeroCompare::GESExt:<br>
     ToExtend = SDValue(CurDAG-><wbr>getMachineNode(Is32Bit ? PPC::NOR : PPC::NOR8,<br>
@@ -2850,7 +2849,6 @@ SDValue PPCDAGToDAGISel::<wbr>getCompoundZero<br>
   assert(Is32Bit && "Should have handled the 32-bit sequences above.");<br>
   // For 32-bit sequences, the extensions differ between GE/LE cases.<br>
   switch (CmpTy) {<br>
-  default: llvm_unreachable("Unknown Zero-comparison type.");<br>
   case ZeroCompare::GEZExt: {<br>
     SDValue ShiftOps[] =<br>
       { ToExtend, getI32Imm(1, dl), getI32Imm(31, dl), getI32Imm(31, dl) };<br>
@@ -2867,6 +2865,11 @@ SDValue PPCDAGToDAGISel::<wbr>getCompoundZero<br>
     return SDValue(CurDAG-><wbr>getMachineNode(PPC::ADDI, dl, MVT::i32, ToExtend,<br>
                                           getI32Imm(-1, dl)), 0);<br>
   }<br>
+<br>
+  // Some compilers warn if there's a default label in the switch above, others<br>
+  // warn if there isn't a return statement here or in a default label. Appease<br>
+  // both (even though this is unreachable).<br>
+  return SDValue();<br></blockquote><div><br></div><div>You can just use `llvm_unreachable` here instead of the return.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 }<br>
<br>
 /// Produces a zero-extended result of comparing two 32-bit values according to<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>