<div dir="ltr">Nice! (also those asserts didn't work - string literal is always true (always a non-null pointer) :) )</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 2, 2017 at 12:12 PM Tobias Grosser via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grosser<br>
Date: Wed Aug  2 12:11:46 2017<br>
New Revision: 309856<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309856&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=309856&view=rev</a><br>
Log:<br>
Replace asserts with llvm_unreachable to clarify intent<br>
<br>
Modified:<br>
    polly/trunk/lib/Support/RegisterPasses.cpp<br>
<br>
Modified: polly/trunk/lib/Support/RegisterPasses.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Support/RegisterPasses.cpp?rev=309856&r1=309855&r2=309856&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Support/RegisterPasses.cpp?rev=309856&r1=309855&r2=309856&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/lib/Support/RegisterPasses.cpp (original)<br>
+++ polly/trunk/lib/Support/RegisterPasses.cpp Wed Aug  2 12:11:46 2017<br>
@@ -464,7 +464,7 @@ static void buildDefaultPollyPipeline(Fu<br>
     case OPTIMIZER_NONE:<br>
       break; /* Do nothing */<br>
     case OPTIMIZER_ISL:<br>
-      assert("ISL optimizer is not implemented");<br>
+      llvm_unreachable("ISL optimizer is not implemented");<br>
       break;<br>
     }<br>
<br>
@@ -482,7 +482,7 @@ static void buildDefaultPollyPipeline(Fu<br>
   }<br>
 #ifdef GPU_CODEGEN<br>
   else<br>
-    assert("Hybrid Target with GPU support is not implemented");<br>
+    llvm_unreachable("Hybrid Target with GPU support is not implemented");<br>
 #endif<br>
<br>
   PM.addPass(CodePreparationPass());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>