<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 4, 2017 at 12:25 PM, George Karpenkov <span dir="ltr"><<a href="mailto:ekarpenkov@apple.com" target="_blank">ekarpenkov@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">indeed, if(TARGET) seems order-dependent, and hence I don’t know now how to check whether asan/clang targets exist<div>at the time when CMake for libFuzzer runs.</div><div>Maybe just make the check-fuzzer registration opt-in? (E.g. one would have to run cmake -DINCLUDE_LIBFUZZER_TESTS=ON )</div></div></blockquote><div><br></div><div>Let's do this  now to fix the bots. </div><div>And then try to figure out what to do (maybe still move the code to compiler-rt)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="h5"><div><br><div><blockquote type="cite"><div>On Aug 4, 2017, at 12:15 PM, George Karpenkov via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="m_5158401180025494835Apple-interchange-newline"><div><div style="word-wrap:break-word">looking into this now.<div><div><blockquote type="cite"><div>On Aug 4, 2017, at 12:05 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:</div><br class="m_5158401180025494835Apple-interchange-newline"><div><div dir="ltr">Ping. Are you looking into this? </div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 4, 2017 at 11:31 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">... from *all* builds </div></blockquote></div></div></div></blockquote></div></div></div></div></blockquote><blockquote type="cite"><div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_5158401180025494835HOEnZb"><div class="m_5158401180025494835h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 4, 2017 at 11:31 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think this removed check-fuzzer from old build, at least I get this: <div><div>ninja: error: unknown target 'check-fuzzer'</div></div><div><br></div></div><div class="m_5158401180025494835m_6649176913568328628HOEnZb"><div class="m_5158401180025494835m_6649176913568328628h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 4, 2017 at 10:43 AM, George Karpenkov via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: george.karpenkov<br>
Date: Fri Aug  4 10:43:29 2017<br>
New Revision: 310077<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310077&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=310077&view=rev</a><br>
Log:<br>
Fixing buildbots: do not register check-fuzzer if clang or asan are not<br>
present.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt<br>
<br>
Modified: llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/CMakeLists.txt?rev=310077&r1=310076&r2=310077&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Fuzzer/te<wbr>st/CMakeLists.txt?rev=310077&r<wbr>1=310076&r2=310077&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt (original)<br>
+++ llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt Fri Aug  4 10:43:29 2017<br>
@@ -47,20 +47,23 @@ include_directories(..)<br>
 set(LIBFUZZER_TEST_COMPILER ${LLVM_RUNTIME_OUTPUT_INTDIR}/<wbr>clang)<br>
 set(LIBFUZZER_TEST_CXX_COMPIL<wbr>ER ${LLVM_RUNTIME_OUTPUT_INTDIR}/<wbr>clang++)<br>
<br>
-# LIT-based libFuzzer tests.<br>
-configure_lit_site_cfg(<br>
-  ${CMAKE_CURRENT_SOURCE_DIR}/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank">li<wbr>t.site.cfg.in</a><br>
-  ${CMAKE_CURRENT_BINARY_DIR}/li<wbr>t.site.cfg<br>
-  )<br>
+if ((TARGET asan) AND (TARGET clang))<br>
+  # LIT-based libFuzzer tests.<br>
+  configure_lit_site_cfg(<br>
+    ${CMAKE_CURRENT_SOURCE_DIR}/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank">li<wbr>t.site.cfg.in</a><br>
+    ${CMAKE_CURRENT_BINARY_DIR}/li<wbr>t.site.cfg<br>
+    )<br>
<br>
-# libFuzzer unit tests.<br>
-configure_lit_site_cfg(<br>
-  ${CMAKE_CURRENT_SOURCE_DIR}/un<wbr>it/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank">lit.site.cfg.in</a><br>
-  ${CMAKE_CURRENT_BINARY_DIR}/un<wbr>it/lit.site.cfg<br>
-  )<br>
+  # libFuzzer unit tests.<br>
+  configure_lit_site_cfg(<br>
+    ${CMAKE_CURRENT_SOURCE_DIR}/un<wbr>it/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank">lit.site.cfg.in</a><br>
+    ${CMAKE_CURRENT_BINARY_DIR}/un<wbr>it/lit.site.cfg<br>
+    )<br>
<br>
-add_lit_testsuite(check-fuzze<wbr>r "Running Fuzzer tests"<br>
+  add_lit_testsuite(check-fuzzer "Running Fuzzer tests"<br>
     ${CMAKE_CURRENT_BINARY_DIR}<br>
     DEPENDS LLVMFuzzer-Unittest)<br>
<br>
-add_dependencies(check-fuzzer LLVMFuzzer asan clang llvm-symbolizer FileCheck sancov not)<br>
+  add_dependencies(check-fuzzer LLVMFuzzer asan clang llvm-symbolizer FileCheck sancov not)<br>
+endif()<br>
+<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></blockquote></div><br></div></div>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div>