<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">indeed, if(TARGET) seems order-dependent, and hence I don’t know now how to check whether asan/clang targets exist<div class="">at the time when CMake for libFuzzer runs.</div><div class="">Maybe just make the check-fuzzer registration opt-in? (E.g. one would have to run cmake -DINCLUDE_LIBFUZZER_TESTS=ON )</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 4, 2017, at 12:15 PM, George Karpenkov via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">looking into this now.<div class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 4, 2017, at 12:05 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" class="">kcc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Ping. Are you looking into this? </div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Aug 4, 2017 at 11:31 AM, Kostya Serebryany <span dir="ltr" class=""><<a href="mailto:kcc@google.com" target="_blank" class="">kcc@google.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">... from *all* builds </div></blockquote></div></div></div></blockquote></div></div></div></div></blockquote><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Aug 4, 2017 at 11:31 AM, Kostya Serebryany <span dir="ltr" class=""><<a href="mailto:kcc@google.com" target="_blank" class="">kcc@google.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">I think this removed check-fuzzer from old build, at least I get this: <div class=""><div class="">ninja: error: unknown target 'check-fuzzer'</div></div><div class=""><br class=""></div></div><div class="m_6649176913568328628HOEnZb"><div class="m_6649176913568328628h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Aug 4, 2017 at 10:43 AM, George Karpenkov via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: george.karpenkov<br class="">
Date: Fri Aug 4 10:43:29 2017<br class="">
New Revision: 310077<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310077&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject?rev=310077&view=rev</a><br class="">
Log:<br class="">
Fixing buildbots: do not register check-fuzzer if clang or asan are not<br class="">
present.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Fuzzer/test/CMa<wbr class="">keLists.txt<br class="">
<br class="">
Modified: llvm/trunk/lib/Fuzzer/test/CMa<wbr class="">keLists.txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/CMakeLists.txt?rev=310077&r1=310076&r2=310077&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/llvm/trunk/lib/Fuzzer/te<wbr class="">st/CMakeLists.txt?rev=310077&r<wbr class="">1=310076&r2=310077&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/Fuzzer/test/CMa<wbr class="">keLists.txt (original)<br class="">
+++ llvm/trunk/lib/Fuzzer/test/CMa<wbr class="">keLists.txt Fri Aug 4 10:43:29 2017<br class="">
@@ -47,20 +47,23 @@ include_directories(..)<br class="">
set(LIBFUZZER_TEST_COMPILER ${LLVM_RUNTIME_OUTPUT_INTDIR}/<wbr class="">clang)<br class="">
set(LIBFUZZER_TEST_CXX_COMPIL<wbr class="">ER ${LLVM_RUNTIME_OUTPUT_INTDIR}/<wbr class="">clang++)<br class="">
<br class="">
-# LIT-based libFuzzer tests.<br class="">
-configure_lit_site_cfg(<br class="">
- ${CMAKE_CURRENT_SOURCE_DIR}/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank" class="">li<wbr class="">t.site.cfg.in</a><br class="">
- ${CMAKE_CURRENT_BINARY_DIR}/li<wbr class="">t.site.cfg<br class="">
- )<br class="">
+if ((TARGET asan) AND (TARGET clang))<br class="">
+ # LIT-based libFuzzer tests.<br class="">
+ configure_lit_site_cfg(<br class="">
+ ${CMAKE_CURRENT_SOURCE_DIR}/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank" class="">li<wbr class="">t.site.cfg.in</a><br class="">
+ ${CMAKE_CURRENT_BINARY_DIR}/li<wbr class="">t.site.cfg<br class="">
+ )<br class="">
<br class="">
-# libFuzzer unit tests.<br class="">
-configure_lit_site_cfg(<br class="">
- ${CMAKE_CURRENT_SOURCE_DIR}/un<wbr class="">it/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank" class="">lit.site.cfg.in</a><br class="">
- ${CMAKE_CURRENT_BINARY_DIR}/un<wbr class="">it/lit.site.cfg<br class="">
- )<br class="">
+ # libFuzzer unit tests.<br class="">
+ configure_lit_site_cfg(<br class="">
+ ${CMAKE_CURRENT_SOURCE_DIR}/un<wbr class="">it/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank" class="">lit.site.cfg.in</a><br class="">
+ ${CMAKE_CURRENT_BINARY_DIR}/un<wbr class="">it/lit.site.cfg<br class="">
+ )<br class="">
<br class="">
-add_lit_testsuite(check-fuzze<wbr class="">r "Running Fuzzer tests"<br class="">
+ add_lit_testsuite(check-fuzzer "Running Fuzzer tests"<br class="">
${CMAKE_CURRENT_BINARY_DIR}<br class="">
DEPENDS LLVMFuzzer-Unittest)<br class="">
<br class="">
-add_dependencies(check-fuzzer LLVMFuzzer asan clang llvm-symbolizer FileCheck sancov not)<br class="">
+ add_dependencies(check-fuzzer LLVMFuzzer asan clang llvm-symbolizer FileCheck sancov not)<br class="">
+endif()<br class="">
+<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>