<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 08/02/2017 03:16 AM, Hiroshi 7 Inoue
wrote:<br>
</div>
<blockquote
cite="mid:OF09373A5D.EEB94639-ON49258170.002D3494-49258170.002D7021@notes.na.collabserv.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p><font size="2">Hi,</font><br>
<br>
<font size="2">I updated my patch in Phabricator based on
comments from Hal and Matthias.</font><br>
<a moz-do-not-send="true" href="https://reviews.llvm.org/D35907"><font
size="2">https://reviews.llvm.org/D35907</font></a><br>
<br>
<font size="2">I will commit the new patch if it looks ok for
everyone.</font><br>
</p>
</blockquote>
<br>
Please commit the update. In the future, please don't commit a
non-trivial change like this without an explicit approval.<br>
<br>
Thanks again,<br>
Hal<br>
<br>
<blockquote
cite="mid:OF09373A5D.EEB94639-ON49258170.002D3494-49258170.002D7021@notes.na.collabserv.com"
type="cite">
<p><font size="2">Thank you.</font><br>
<br>
<font size="2">Hiroshi</font><br>
<font size="2"><br>
-----<br>
Hiroshi Inoue <a class="moz-txt-link-rfc2396E" href="mailto:inouehrs@jp.ibm.com"><inouehrs@jp.ibm.com></a><br>
IBM Research - Tokyo<br>
</font><br>
<br>
<tt><font size="2"><a class="moz-txt-link-abbreviated" href="mailto:hwennborg@google.com">hwennborg@google.com</a> wrote on 2017/08/02
08:41:33:<br>
<br>
> From: Hans Wennborg <a class="moz-txt-link-rfc2396E" href="mailto:hans@chromium.org"><hans@chromium.org></a></font></tt><br>
<tt><font size="2">> To: Hal Finkel <a class="moz-txt-link-rfc2396E" href="mailto:hfinkel@anl.gov"><hfinkel@anl.gov></a></font></tt><br>
<tt><font size="2">> Cc: Matthias Braun
<a class="moz-txt-link-rfc2396E" href="mailto:matze@braunis.de"><matze@braunis.de></a>, Hiroshi Inoue <br>
> <a class="moz-txt-link-rfc2396E" href="mailto:inouehrs@jp.ibm.com"><inouehrs@jp.ibm.com></a>, llvm-commits
<a class="moz-txt-link-rfc2396E" href="mailto:llvm-commits@lists.llvm.org"><llvm-commits@lists.llvm.org></a></font></tt><br>
<tt><font size="2">> Date: 2017/08/02 08:41</font></tt><br>
<tt><font size="2">> Subject: Re: [llvm] r309651 -
[StackColoring] Update AliasAnalysis <br>
> information in stack coloring pass</font></tt><br>
<tt><font size="2">> Sent by: <a class="moz-txt-link-abbreviated" href="mailto:hwennborg@google.com">hwennborg@google.com</a></font></tt><br>
<tt><font size="2">> <br>
> On Tue, Aug 1, 2017 at 10:51 AM, Hal Finkel
<a class="moz-txt-link-rfc2396E" href="mailto:hfinkel@anl.gov"><hfinkel@anl.gov></a> wrote:<br>
> ><br>
> > On 08/01/2017 12:38 PM, Matthias Braun wrote:<br>
> ><br>
> > This is going a little fast, given that Hal had
raised concerns and the<br>
> > patch went in before he responded (at least it
looks like that in phab). I'd<br>
> > like to hear his opinion first, given that my
experience with alias analysis<br>
> > in LLVM is limited.<br>
> ><br>
> ><br>
> > I'd like to see this in 5.0, however, I just
provided a post-commit review<br>
> > and it looks like it will need a small update
before merging.<br>
> <br>
> Sounds good. Thanks!<br>
> <br>
> <br>
> <br>
> > On Aug 1, 2017, at 10:15 AM, Hans Wennborg via
llvm-commits<br>
> > <a class="moz-txt-link-rfc2396E" href="mailto:llvm-commits@lists.llvm.org"><llvm-commits@lists.llvm.org></a> wrote:<br>
> ><br>
> > Matthias, the PR for this was marked as a release
blocker for 5.0.<br>
> > What do you think about merging this?<br>
> ><br>
> > On Mon, Jul 31, 2017 at 8:32 PM, Hiroshi Inoue via
llvm-commits<br>
> > <a class="moz-txt-link-rfc2396E" href="mailto:llvm-commits@lists.llvm.org"><llvm-commits@lists.llvm.org></a> wrote:<br>
> ><br>
> > Author: inouehrs<br>
> > Date: Mon Jul 31 20:32:15 2017<br>
> > New Revision: 309651<br>
> ><br>
> > URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=309651&view=rev">http://llvm.org/viewvc/llvm-project?rev=309651&view=rev</a><br>
> > Log:<br>
> > [StackColoring] Update AliasAnalysis information
in stack coloring pass<br>
> ><br>
> > Stack coloring pass need to maintain AliasAnalysis
information when merging<br>
> > stack slots of different types.<br>
> > Actually, there is a FIXME comment in
StackColoring.cpp<br>
> ><br>
> > // FIXME: In order to enable the use of TBAA when
using AA in CodeGen,<br>
> > // we'll also need to update the TBAA nodes in
MMOs with values<br>
> > // derived from the merged allocas.<br>
> ><br>
> > But, TBAA has been already enabled in CodeGen
without fixing this pass.<br>
> > The incorrect TBAA metadata results in recent
failures in bootstrap test on<br>
> > ppc64le (PR33928) by allowing unsafe instruction
scheduling.<br>
> > Although we observed the problem on ppc64le, this
is a platform neutral<br>
> > issue.<br>
> ><br>
> > This patch makes the stack coloring pass maintains
AliasAnalysis information<br>
> > when merging multiple stack slots.<br>
> ><br>
> ><br>
> > (This is <a moz-do-not-send="true"
href="https://reviews.llvm.org/D35907">https://reviews.llvm.org/D35907</a>)<br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> > <a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Hal Finkel<br>
> > Lead, Compiler Technology and Programming
Languages<br>
> > Leadership Computing Facility<br>
> > Argonne National Laboratory<br>
> <br>
</font></tt><br>
</p>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>