<div dir="ltr">Thanks for that David! I'll close the related bug.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 31, 2017 at 5:17 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">
<p class="m_-2307797981065965542inbox-inbox-p1"><span class="m_-2307797981065965542inbox-inbox-s1">r309517</span></p><div><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 30, 2017 at 9:21 AM Dylan McKay <<a href="mailto:me@dylanmckay.io" target="_blank">me@dylanmckay.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hey David,</div><div dir="ltr"><div><br></div><div>> <span style="font-size:12.8px">Please use SVN revision numbers rather than git hashes in commits</span></div><div><span style="font-size:12.8px">> </span><span style="font-size:12.8px">There's a handy utility to help with this in llvm/utils/git-svn/git-</span><span style="font-size:12.8px">svnreve<wbr>rt - it'll take a git hash to revert, but create a local commit with the SVN revision in the commit message instead.</span></div><div><span style="font-size:12.8px"><br></span></div></div><div dir="ltr"><div><span style="font-size:12.8px">That sounds really handy, thanks for that</span></div></div><div dir="ltr"><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">> </span><span style="font-size:12.8px">Also, I committed a change in r309516 that'll make this test resilient to your change. (so adding the comment lines doesn't throw off the test's checks for line numbers, etc) So you can probably recommit it.</span></div><div><span style="font-size:12.8px"><br></span></div></div><div dir="ltr"><div><span style="font-size:12.8px">Cheers!</span></div></div><div dir="ltr"><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">> </span><span style="font-size:12.8px">That said, redaing the bug, XFAILing for AVR doesn't seem like the right answer - sounds like this would be failing on any </span><span style="font-size:12.8px">Debian machine, AVR, X86, etc. (so XFAIL AVR would have false positives an false negatives - there could be AVR machines where this passes, and non-AVR machines where it fails)</span></div><div><span style="font-size:12.8px"><br></span></div></div><div dir="ltr"><div><span style="font-size:12.8px">I agree that it should be fixed properly, and adding XFAIL is a dirty hack, but I don't have the time to look into it and I'm also not familiar with the symboliser at all.</span></div><div><br></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px"><br></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 31, 2017 at 4:10 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">That said, redaing the bug, XFAILing for AVR doesn't seem like the right answer - sounds like this would be failing on any Debian machine, AVR, X86, etc. (so XFAIL AVR would have false positives an false negatives - there could be AVR machines where this passes, and non-AVR machines where it fails)<br><br>Sounds like the test should be fixed.</div><div class="m_-2307797981065965542m_6666385702687903677HOEnZb"><div class="m_-2307797981065965542m_6666385702687903677h5"><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 30, 2017 at 9:08 AM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Sun, Jul 30, 2017 at 8:38 AM Dylan McKay via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dylanmckay<br>
Date: Sun Jul 30 08:38:07 2017<br>
New Revision: 309515<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309515&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=309515&view=rev</a><br>
Log:<br>
Revert "[AVR] Mark a failing symbolizer test as XFAIL"<br>
<br>
This reverts commit 83a0e876349adb646ba858eb177b22<wbr>b0b4bfc59a.<br></blockquote></div></div><div dir="ltr"><div class="gmail_quote"><div><br>Please use SVN revision numbers rather than git hashes in commits<br>There's a handy utility to help with this in llvm/utils/git-svn/git-<wbr>svnrevert - it'll take a git hash to revert, but create a local commit with the SVN revision in the commit message instead.<br><br>Also, I committed a change in r309516 that'll make this test resilient to your change. (so adding the comment lines doesn't throw off the test's checks for line numbers, etc) So you can probably recommit it.<br><br>(that said, this is probably a bad test - generally good to avoid running the host compiler to test functionality - most of the llvm-symbolizer tests rely on checked in binaries to run over)<br><br>- Dave <br><br></div></div></div><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/test/tools/llvm-<wbr>symbolizer/print_context.c<br>
<br>
Modified: llvm/trunk/test/tools/llvm-<wbr>symbolizer/print_context.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-symbolizer/print_context.c?rev=309515&r1=309514&r2=309515&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-symbolizer/print_context.<wbr>c?rev=309515&r1=309514&r2=<wbr>309515&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/llvm-<wbr>symbolizer/print_context.c (original)<br>
+++ llvm/trunk/test/tools/llvm-<wbr>symbolizer/print_context.c Sun Jul 30 08:38:07 2017<br>
@@ -1,9 +1,6 @@<br>
// REQUIRES: x86_64-linux<br>
// RUN: %host_cc -O0 -g %s -o %t 2>&1<br>
// RUN: %t 2>&1 | llvm-symbolizer -print-source-context-lines=5 -obj=%t | FileCheck %s<br>
-//<br>
-// See PR31870 for more details on the XFAIL<br>
-// XFAIL: avr<br>
<br>
#include <stdio.h><br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></blockquote></div>
</div></div></blockquote></div><br></div>
</blockquote></div></div></div></div>
</blockquote></div><br></div>