<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 24 Jul 2017, at 22:31, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Jul 20, 2017 at 3:25 AM Daniel Sanders via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dsanders<br class="">
Date: Thu Jul 20 03:25:00 2017<br class="">
New Revision: 308599<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=308599&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=308599&view=rev</a><br class="">
Log:<br class="">
[globalisel][tablegen] Fix an issue with lambdas when compiling with older GCC's<br class="">
<br class="">
It seems that G++ 4.8 doesn't accept the 'enum A' in code of the form:<br class="">
enum A { ... };<br class="">
const auto &F = []() -> enum A { ... };<br class="">
However, it does accept:<br class="">
typedef enum { ... } A;<br class="">
const auto &F = []() -> A { ... };<br class=""></blockquote><div class=""><br class="">What if you drop the 'enum' keyword but don't modify the definition of A (leaving it 'enum A { ... }'). The 'typedef enum { ... } A' stuff is generally only needed in C (in C++ you don't need the 'enum' or 'struct' prefix to refer to an enum/struct type, even without the typedef).<br class=""></div></div></div></div></blockquote><div><br class=""></div><div>That works on G++ 4.8 too. If there's a preference then I'm happy to change it.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h?rev=308599&r1=308598&r2=308599&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h?rev=308599&r1=308598&r2=308599&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h (original)<br class="">
+++ llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h Thu Jul 20 03:25:00 2017<br class="">
@@ -29,8 +29,8 @@ bool InstructionSelector::executeMatchTa<br class="">
uint64_t CurrentIdx = 0;<br class="">
SmallVector<uint64_t, 8> OnFailResumeAt;<br class="">
<br class="">
- enum RejectAction { RejectAndGiveUp, RejectAndResume };<br class="">
- auto handleReject = [&]() -> enum RejectAction {<br class="">
+ typedef enum { RejectAndGiveUp, RejectAndResume } RejectAction;<br class="">
+ auto handleReject = [&]() -> RejectAction {<br class="">
DEBUG(dbgs() << CurrentIdx << ": Rejected\n");<br class="">
if (OnFailResumeAt.empty())<br class="">
return RejectAndGiveUp;<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></body></html>