<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thank you, I was actually just about to push the same patch!<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 28, 2017, at 1:33 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" class="">kcc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thanks! </div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Jul 28, 2017 at 1:29 PM, Krzysztof Parzyszek via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kparzysz<br class="">
Date: Fri Jul 28 13:29:29 2017<br class="">
New Revision: 309430<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309430&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=309430&view=rev</a><br class="">
Log:<br class="">
[compiler-rt] Add missing quotation marks to msan_compile invocation<br class="">
<br class="">
Modified:<br class="">
compiler-rt/trunk/lib/msan/<wbr class="">tests/CMakeLists.txt<br class="">
<br class="">
Modified: compiler-rt/trunk/lib/msan/<wbr class="">tests/CMakeLists.txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/tests/CMakeLists.txt?rev=309430&r1=309429&r2=309430&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/compiler-rt/trunk/lib/<wbr class="">msan/tests/CMakeLists.txt?rev=<wbr class="">309430&r1=309429&r2=309430&<wbr class="">view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- compiler-rt/trunk/lib/msan/<wbr class="">tests/CMakeLists.txt (original)<br class="">
+++ compiler-rt/trunk/lib/msan/<wbr class="">tests/CMakeLists.txt Fri Jul 28 13:29:29 2017<br class="">
@@ -85,7 +85,7 @@ set_target_properties(<wbr class="">MsanUnitTests PROP<br class="">
macro(add_msan_tests_for_arch arch kind cflags)<br class="">
# Build gtest instrumented with MSan.<br class="">
set(MSAN_INST_GTEST)<br class="">
- msan_compile(MSAN_INST_GTEST ${COMPILER_RT_GTEST_SOURCE} ${arch} ${kind}<br class="">
+ msan_compile(MSAN_INST_GTEST ${COMPILER_RT_GTEST_SOURCE} ${arch} "${kind}"<br class="">
"${cflags}")<br class="">
<br class="">
# Instrumented tests.<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>