<div dir="ltr">Nice!</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 26, 2017 at 11:47 AM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Wed Jul 26 11:47:49 2017<br>
New Revision: 309153<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309153&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=309153&view=rev</a><br>
Log:<br>
Simplify. NFC.<br>
<br>
Modified:<br>
    lld/trunk/ELF/LinkerScript.cpp<br>
<br>
Modified: lld/trunk/ELF/LinkerScript.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=309153&r1=309152&r2=309153&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/<wbr>LinkerScript.cpp?rev=309153&<wbr>r1=309152&r2=309153&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/LinkerScript.cpp (original)<br>
+++ lld/trunk/ELF/LinkerScript.cpp Wed Jul 26 11:47:49 2017<br>
@@ -66,7 +66,7 @@ uint64_t ExprValue::getSecAddr() const {<br>
   return 0;<br>
 }<br>
<br>
-template <class ELFT> static SymbolBody *addRegular(SymbolAssignment *Cmd) {<br>
+static SymbolBody *addRegular(SymbolAssignment *Cmd) {<br>
   Symbol *Sym;<br>
   uint8_t Visibility = Cmd->Hidden ? STV_HIDDEN : STV_DEFAULT;<br>
   std::tie(Sym, std::ignore) = Symtab->insert(Cmd->Name, /*Type*/ 0, Visibility,<br>
@@ -142,21 +142,6 @@ void LinkerScript::assignSymbol(<wbr>SymbolAs<br>
   }<br>
 }<br>
<br>
-static SymbolBody *addRegularSymbol(<wbr>SymbolAssignment *Cmd) {<br>
-  switch (Config->EKind) {<br>
-  case ELF32LEKind:<br>
-    return addRegular<ELF32LE>(Cmd);<br>
-  case ELF32BEKind:<br>
-    return addRegular<ELF32BE>(Cmd);<br>
-  case ELF64LEKind:<br>
-    return addRegular<ELF64LE>(Cmd);<br>
-  case ELF64BEKind:<br>
-    return addRegular<ELF64BE>(Cmd);<br>
-  default:<br>
-    llvm_unreachable("unknown Config->EKind");<br>
-  }<br>
-}<br>
-<br>
 void LinkerScript::addSymbol(<wbr>SymbolAssignment *Cmd) {<br>
   if (Cmd->Name == ".")<br>
     return;<br>
@@ -167,7 +152,7 @@ void LinkerScript::addSymbol(<wbr>SymbolAssig<br>
   if (Cmd->Provide && (!B || B->isDefined()))<br>
     return;<br>
<br>
-  Cmd->Sym = addRegularSymbol(Cmd);<br>
+  Cmd->Sym = addRegular(Cmd);<br>
 }<br>
<br>
 bool SymbolAssignment::classof(<wbr>const BaseCommand *C) {<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>