<div dir="ltr">Thanks!<div>Teresa</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 25, 2017 at 3:51 PM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Tue Jul 25 15:51:05 2017<br>
New Revision: 309048<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309048&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=309048&view=rev</a><br>
Log:<br>
LTO: Handle sections with valid C names.<br>
<br>
These can be referenced with __start_/__stop_ symbols. I will try to make<br>
this more precise in a followup patch.<br>
<br>
Added:<br>
    lld/trunk/test/ELF/lto/<wbr>section-name.ll<br>
Modified:<br>
    lld/trunk/ELF/LTO.cpp<br>
<br>
Modified: lld/trunk/ELF/LTO.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LTO.cpp?rev=309048&r1=309047&r2=309048&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/LTO.cpp?<wbr>rev=309048&r1=309047&r2=<wbr>309048&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/LTO.cpp (original)<br>
+++ lld/trunk/ELF/LTO.cpp Tue Jul 25 15:51:05 2017<br>
@@ -136,8 +136,9 @@ void BitcodeCompiler::add(<wbr>BitcodeFile &F<br>
     // be removed.<br>
     R.Prevailing = !ObjSym.isUndefined() && B->File == &F;<br>
<br>
-    R.VisibleToRegularObj =<br>
-        Sym->IsUsedInRegularObj || (R.Prevailing && Sym->includeInDynsym());<br>
+    R.VisibleToRegularObj = Sym->IsUsedInRegularObj ||<br>
+                            (R.Prevailing && Sym->includeInDynsym()) ||<br>
+                            isValidCIdentifier(ObjSym.<wbr>getSectionName());<br>
     if (R.Prevailing)<br>
       undefine(Sym);<br>
     R.LinkerRedefined = Config->RenamedSymbols.count(<wbr>Sym);<br>
<br>
Added: lld/trunk/test/ELF/lto/<wbr>section-name.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/section-name.ll?rev=309048&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/test/ELF/<wbr>lto/section-name.ll?rev=<wbr>309048&view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/test/ELF/lto/<wbr>section-name.ll (added)<br>
+++ lld/trunk/test/ELF/lto/<wbr>section-name.ll Tue Jul 25 15:51:05 2017<br>
@@ -0,0 +1,11 @@<br>
+; REQUIRES: x86<br>
+; RUN: llvm-as %s -o %t.o<br>
+; RUN: ld.lld %t.o -o %t.so -shared<br>
+; RUN: llvm-readelf -s %t.so | FileCheck %s<br>
+<br>
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:<wbr>32:64-S128"<br>
+target triple = "x86_64-unknown-linux-gnu"<br>
+<br>
+@foo = hidden global i32 42, section "foo_section"<br>
+<br>
+; CHECK: foo_section PROGBITS<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div>