<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Begin forwarded message:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">From: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Juergen Ributzka via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">[PATCH] D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">July 26, 2017 at 11:43:25 AM PDT<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:juergen@ributzka.de" class="">juergen@ributzka.de</a><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Cc: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:hiraditya@msn.com" class="">hiraditya@msn.com</a>, <a href="mailto:zturner@google.com" class="">zturner@google.com</a><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Reply-To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:reviews+D35908+public+a030263ec48807c6@reviews.llvm.org" class="">reviews+D35908+public+a030263ec48807c6@reviews.llvm.org</a><br class=""></span></div><br class=""><div class=""><div class="">ributzka created this revision.<br class="">Herald added a subscriber: hiraditya.<br class=""><br class="">The YAML parser already uses a BumpPtrAllocator for all its Nodes, but inside<br class="">YAMLTraits we still use make_unique for HNodes. This results in lot of malloc<br class="">traffic when parsing large or many YAML files.<br class=""><br class="">Most HNode sub-classes can use a simple BumpPtrAllocator, but there are two<br class="">sub-classes that need SpecificBumpPtrAllocators to call the proper destructor.<br class=""><br class=""><br class=""><a href="https://reviews.llvm.org/D35908" class="">https://reviews.llvm.org/D35908</a><br class=""><br class="">Files:<br class=""> llvm/include/llvm/Support/YAMLTraits.h<br class=""> llvm/lib/Support/YAMLTraits.cpp<br class=""><br class=""></div></div></blockquote></div></body></html>