<div dir="ltr">Hi Davide,<div><br></div><div>I've started getting these test failures from check-llvm. My gold version is 2.24. Maybe need to make the checks less precise?</div><div><br></div><div><div>FAIL: LLVM :: tools/gold/X86/multiple-data.s (21000 of 21507)</div><div>******************** TEST 'LLVM :: tools/gold/X86/multiple-data.s' FAILED ********************</div><div>Script:</div><div>--</div><div>echo ".data.tin" > ra/test/tools/gold/X86/Output/multiple-data.s.tmp_order_lto.txt</div><div>echo ".data.dipsy" >> ra/test/tools/gold/X86/Output/multiple-data.s.tmp_order_lto.txt</div><div>echo ".data.pat" >> ra/test/tools/gold/X86/Output/multiple-data.s.tmp_order_lto.txt</div><div>ra/./bin/llvm-mc llvm/test/tools/gold/X86/multiple-data.s -o ra/test/tools/gold/X86/Output/multiple-data.s.tmp.o -filetype=obj -triple=x86_64-unknown-linux-gnu</div><div>ra/./bin/llvm-as llvm/test/tools/gold/X86/Inputs/multiple-data.ll -o ra/test/tools/gold/X86/Output/multiple-data.s.tmp2.o</div><div>/usr/bin/ld.gold -plugin ra/./lib/LLVMgold.so -m elf_x86_64 -o ra/test/tools/gold/X86/Output/multiple-data.s.tmp.exe ra/test/tools/gold/X86/Output/multiple-data.s.tmp2.o ra/test/tools/gold/X86/Output/multiple-data.s.tmp.o --section-ordering-file=ra/test/tools/gold/X86/Output/multiple-data.s.tmp_order_lto.txt</div><div>ra/./bin/llvm-readobj -elf-output-style=GNU -t ra/test/tools/gold/X86/Output/multiple-data.s.tmp.exe | ra/./bin/FileCheck llvm/test/tools/gold/X86/multiple-data.s</div><div>--</div><div>Exit Code: 1</div><div><br></div><div>Command Output (stderr):</div><div>--</div><div>llvm/test/tools/gold/X86/multiple-data.s:16:15: error: expected string not found in input</div><div># CHECK-NEXT: 2: 0000000000401104 0 NOTYPE GLOBAL DEFAULT ABS _end</div><div> ^</div><div><stdin>:6:2: note: scanning from here</div><div> 2: 0000000000401100 4 OBJECT GLOBAL DEFAULT 2 pat</div><div> ^</div><div><stdin>:12:2: note: possible intended match here</div><div> 8: 0000000000401104 0 NOTYPE GLOBAL DEFAULT ABS _end</div><div> ^</div><div><br></div><div>--</div><div><br></div><div>********************</div><div>FAIL: LLVM :: tools/gold/X86/multiple-sections.ll (21005 of 21507)</div><div>******************** TEST 'LLVM :: tools/gold/X86/multiple-sections.ll' FAILED ********************</div><div>Script:</div><div>--</div><div>echo ".text.tin" > ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp_order_lto.txt</div><div>echo ".text._start" >> ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp_order_lto.txt</div><div>echo ".text.pat" >> ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp_order_lto.txt</div><div>ra/./bin/llvm-as llvm/test/tools/gold/X86/multiple-sections.ll -o ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp.o</div><div>/usr/bin/ld.gold -plugin ra/./lib/LLVMgold.so -m elf_x86_64 -o ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp.exe ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp.o --section-ordering-file=ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp_order_lto.txt</div><div>ra/./bin/llvm-readobj -elf-output-style=GNU -t ra/test/tools/gold/X86/Output/multiple-sections.ll.tmp.exe | ra/./bin/FileCheck llvm/test/tools/gold/X86/multiple-sections.ll</div><div>--</div><div>Exit Code: 1</div><div><br></div><div>Command Output (stderr):</div><div>--</div><div>llvm/test/tools/gold/X86/multiple-sections.ll:18:15: error: expected string not found in input</div><div>; CHECK-NEXT: 4: 0000000000000000 0 NOTYPE GLOBAL DEFAULT ABS _end</div><div> ^</div><div><stdin>:8:2: note: scanning from here</div><div> 4: 00000000004000c0 15 FUNC GLOBAL DEFAULT 1 _start</div><div> ^</div><div><stdin>:11:2: note: possible intended match here</div><div> 7: 0000000000000000 0 NOTYPE GLOBAL DEFAULT ABS _end</div><div> ^</div><div><br></div><div>--</div><div><br></div><div>********************</div><div>Testing Time: 44.69s</div><div>********************</div><div>Failing Tests (2):</div><div> LLVM :: tools/gold/X86/multiple-data.s</div><div> LLVM :: tools/gold/X86/multiple-sections.ll</div><div><br></div><div> Expected Passes : 21086</div><div> Expected Failures : 137</div><div> Unsupported Tests : 282</div><div> Unexpected Failures: 2</div></div><div><br></div><div>Peter<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 25, 2017 at 6:47 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Tue Jul 25 18:47:17 2017<br>
New Revision: 309075<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309075&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=309075&view=rev</a><br>
Log:<br>
[gold] Enable data-sections by default for the gold-plugin.<br>
<br>
Follow up to r309056.<br>
<br>
Added:<br>
llvm/trunk/test/tools/gold/<wbr>X86/Inputs/multiple-data.ll<br>
llvm/trunk/test/tools/gold/<wbr>X86/multiple-data.s<br>
Modified:<br>
llvm/trunk/tools/gold/gold-<wbr>plugin.cpp<br>
<br>
Added: llvm/trunk/test/tools/gold/<wbr>X86/Inputs/multiple-data.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/Inputs/multiple-data.ll?rev=309075&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>gold/X86/Inputs/multiple-data.<wbr>ll?rev=309075&view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/gold/<wbr>X86/Inputs/multiple-data.ll (added)<br>
+++ llvm/trunk/test/tools/gold/<wbr>X86/Inputs/multiple-data.ll Tue Jul 25 18:47:17 2017<br>
@@ -0,0 +1,6 @@<br>
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:<wbr>32:64-S128"<br>
+target triple = "x86_64-unknown-linux-gnu"<br>
+<br>
+@pat = global i32 33, align 4<br>
+@tin = global i32 33, align 4<br>
+@dipsy = global i32 33, align 4<br>
<br>
Added: llvm/trunk/test/tools/gold/<wbr>X86/multiple-data.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/multiple-data.s?rev=309075&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>gold/X86/multiple-data.s?rev=<wbr>309075&view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/gold/<wbr>X86/multiple-data.s (added)<br>
+++ llvm/trunk/test/tools/gold/<wbr>X86/multiple-data.s Tue Jul 25 18:47:17 2017<br>
@@ -0,0 +1,28 @@<br>
+# RUN: echo ".data.tin" > %t_order_lto.txt<br>
+# RUN: echo ".data.dipsy" >> %t_order_lto.txt<br>
+# RUN: echo ".data.pat" >> %t_order_lto.txt<br>
+<br>
+# RUN: llvm-mc %s -o %t.o -filetype=obj -triple=x86_64-unknown-linux-<wbr>gnu<br>
+# RUN: llvm-as %p/Inputs/multiple-data.ll -o %t2.o<br>
+# RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \<br>
+# RUN: -m elf_x86_64 -o %t.exe %t2.o %t.o \<br>
+# RUN: --section-ordering-file=%t_<wbr>order_lto.txt<br>
+# RUN: llvm-readobj -elf-output-style=GNU -t %t.exe | FileCheck %s<br>
+<br>
+# CHECK: Symbol table '.symtab' contains 9 entries:<br>
+# CHECK-NEXT: Num: Value Size Type Bind Vis Ndx Name<br>
+# CHECK-NEXT: 0: 0000000000000000 0 NOTYPE LOCAL DEFAULT UND<br>
+# CHECK-NEXT: 1: 0000000000000000 0 FILE LOCAL DEFAULT ABS ld-temp.o<br>
+# CHECK-NEXT: 2: 0000000000401104 0 NOTYPE GLOBAL DEFAULT ABS _end<br>
+# CHECK-NEXT: 3: 0000000000401104 0 NOTYPE GLOBAL DEFAULT ABS __bss_start<br>
+# CHECK-NEXT: 4: 0000000000401104 0 NOTYPE GLOBAL DEFAULT ABS _edata<br>
+# CHECK-NEXT: 5: 00000000004000e8 0 NOTYPE GLOBAL DEFAULT 1 _start<br>
+# CHECK-NEXT: 6: 00000000004010fc 4 OBJECT GLOBAL DEFAULT 2 dipsy<br>
+# CHECK-NEXT: 7: 00000000004010f8 4 OBJECT GLOBAL DEFAULT 2 tin<br>
+# CHECK-NEXT: 8: 0000000000401100 4 OBJECT GLOBAL DEFAULT 2 pat<br>
+<br>
+.globl _start<br>
+_start:<br>
+ movl $pat, %ecx<br>
+ movl $dipsy, %ebx<br>
+ movl $tin, %eax<br>
<br>
Modified: llvm/trunk/tools/gold/gold-<wbr>plugin.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=309075&r1=309074&r2=309075&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/gold/<wbr>gold-plugin.cpp?rev=309075&r1=<wbr>309074&r2=309075&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/gold/gold-<wbr>plugin.cpp (original)<br>
+++ llvm/trunk/tools/gold/gold-<wbr>plugin.cpp Tue Jul 25 18:47:17 2017<br>
@@ -750,8 +750,9 @@ static std::unique_ptr<LTO> createLTO()<br>
// FIXME: Check the gold version or add a new option to enable them.<br>
Conf.Options.<wbr>RelaxELFRelocations = false;<br>
<br>
- // Enable function sections by default.<br>
+ // Enable function/data sections by default.<br>
Conf.Options.FunctionSections = true;<br>
+ Conf.Options.DataSections = true;<br>
<br>
Conf.MAttrs = MAttrs;<br>
Conf.RelocModel = RelocationModel;<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>