<div dir="ltr">Even better, thanks...</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 25, 2017 at 2:03 PM, Chris Bieneman <span dir="ltr"><<a href="mailto:beanz@apple.com" target="_blank">beanz@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Yep. See r309030.<span class="HOEnZb"><font color="#888888"><div><br></div><div>-Chris</div></font></span><div><div class="h5"><div><br><div><blockquote type="cite"><div>On Jul 25, 2017, at 2:00 PM, don hinton <<a href="mailto:hintonda@gmail.com" target="_blank">hintonda@gmail.com</a>> wrote:</div><br class="m_947083218012962000Apple-interchange-newline"><div><div dir="ltr">This causes a warning:<div><br></div><div><div>CMake Warning (dev) in cmake/modules/TableGen.cmake:</div><div> A logical block opening on the line</div><div><br></div><div> /Users/dhinton/projects/llvm_<wbr>project/llvm/cmake/modules/<wbr>TableGen.cmake:113 (if)</div><div><br></div><div> closes on the line</div><div><br></div><div> /Users/dhinton/projects/llvm_<wbr>project/llvm/cmake/modules/<wbr>TableGen.cmake:124 (endif)</div><div><br></div><div> with mis-matching arguments.</div><div>Call Stack (most recent call first):</div><div> CMakeLists.txt:833 (include)</div><div>This warning is for project developers. Use -Wno-dev to suppress it.</div></div><div><br></div><div><br></div><div>I think you just need to:</div><div><br></div><div><div>diff --git a/cmake/modules/TableGen.cmake b/cmake/modules/TableGen.cmake</div><div>index 8ee7f970991..7a3c50bb63f 100644</div><div>--- a/cmake/modules/TableGen.cmake</div><div>+++ b/cmake/modules/TableGen.cmake</div><div>@@ -121,7 +121,7 @@ if(LLVM_USE_HOST_TOOLS AND NOT TARGET NATIVE_LIB_LLVMTABLEGEN)</div><div> COMMENT "Building libLLVMTableGen for native TableGen..."</div><div> USES_TERMINAL)</div><div> add_custom_target(NATIVE_LIB_<wbr>LLVMTABLEGEN DEPENDS LIB_LLVMTABLEGEN)</div><div>-endif(LLVM_USE_HOST_TOOLS)</div><div>+endif(LLVM_USE_HOST_TOOLS AND NOT TARGET NATIVE_LIB_LLVMTABLEGEN)</div><div><br></div><div> macro(add_tablegen target project)</div><div> set(${target}_OLD_LLVM_LINK_<wbr>COMPONENTS ${LLVM_LINK_COMPONENTS})</div></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 25, 2017 at 1:53 PM, Chris Bieneman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: cbieneman<br>
Date: Tue Jul 25 13:53:31 2017<br>
New Revision: 309029<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309029&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=309029&view=rev</a><br>
Log:<br>
[CMake] Allow TableGen.cmake to be included multiple times<br>
<br>
This patch allows TableGen.cmake to be safely included multiple times in sub-projects.<br>
<br>
Modified:<br>
llvm/trunk/cmake/modules/Table<wbr>Gen.cmake<br>
<br>
Modified: llvm/trunk/cmake/modules/Table<wbr>Gen.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/TableGen.cmake?rev=309029&r1=309028&r2=309029&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/cmake/modules<wbr>/TableGen.cmake?rev=309029&r1=<wbr>309028&r2=309029&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/cmake/modules/Table<wbr>Gen.cmake (original)<br>
+++ llvm/trunk/cmake/modules/Table<wbr>Gen.cmake Tue Jul 25 13:53:31 2017<br>
@@ -110,7 +110,7 @@ function(add_public_tablegen_t<wbr>arget targ<br>
set(LLVM_COMMON_DEPENDS ${LLVM_COMMON_DEPENDS} ${target} PARENT_SCOPE)<br>
endfunction()<br>
<br>
-if(LLVM_USE_HOST_TOOLS)<br>
+if(LLVM_USE_HOST_TOOLS AND NOT TARGET NATIVE_LIB_LLVMTABLEGEN)<br>
llvm_ExternalProject_<wbr>BuildCmd(tblgen_build_cmd LLVMSupport<br>
${LLVM_NATIVE_BUILD}<br>
CONFIGURATION Release)<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div>