<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">This is still incomplete:</div><div class=""><br class=""></div><div class="">$ lnt admin get-run 223476</div><div class="">$ lnt checkformat run_223476.json</div><div class="">...</div><div class=""><div class="">Traceback (most recent call last):</div><div class=""> File "/Users/mbraun/dev/lnt/lnt/util/ImportData.py", line 91, in import_and_report</div><div class=""> success, run = ts.importDataFromDict(data, commit, config=db_config)</div><div class=""> File "/Users/mbraun/dev/lnt/lnt/server/db/testsuitedb.py", line 937, in importDataFromDict</div><div class=""> machine, inserted = self._getOrCreateMachine(data['machine'])</div><div class="">KeyError: 'machine'</div></div><div class=""><br class=""></div><div class="">- Matthias</div><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 19, 2017, at 5:30 PM, Chris Matthews via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Fixed in r308570.<div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 19, 2017, at 5:28 PM, Chris Matthews <<a href="mailto:chris.matthews@apple.com" class="">chris.matthews@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ah, thanks. At least I checked 999 was not there!<div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 19, 2017, at 5:22 PM, Matthias Braun <<a href="mailto:mbraun@apple.com" class="">mbraun@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline">On Jul 19, 2017, at 5:09 PM, Chris Matthews via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><br class="">Author: cmatthews<br class="">Date: Wed Jul 19 17:09:11 2017<br class="">New Revision: 308565<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=308565&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=308565&view=rev</a><br class="">Log:<br class="">LNT API run roundtrips<br class=""><br class="">Allow LNT runs to be downloaded from the API in a format that they can<br class="">be inserted back into the same or other LNT instances. This can be used<br class="">to move runs between LNT instances, or modify them.<br class=""><br class="">I make some changes to the REST API to make the format closer to what we<br class="">expect, then ignore some fields (like ID) when importing.<br class=""><br class=""><br class="">Modified: lnt/trunk/tests/server/ui/test_api_modify.py<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/lnt/trunk/tests/server/ui/test_api_modify.py?rev=308565&r1=308564&r2=308565&view=diff" class="">http://llvm.org/viewvc/llvm-project/lnt/trunk/tests/server/ui/test_api_modify.py?rev=308565&r1=308564&r2=308565&view=diff</a><br class="">==============================================================================<br class="">--- lnt/trunk/tests/server/ui/test_api_modify.py (original)<br class="">+++ lnt/trunk/tests/server/ui/test_api_modify.py Wed Jul 19 17:09:11 2017<br class="">@@ -62,7 +62,7 @@ class JSONAPIDeleteTester(unittest.TestC<br class=""> client = self.client<br class=""><br class=""> j = check_json(client, 'api/db_default/v4/nts/runs/1')<br class="">- sample_ids = [s['id'] for s in j['samples']]<br class="">+ sample_ids = [s['id'] for s in j['tests']]<br class=""> self.assertNotEqual(len(sample_ids), 0)<br class=""> for sid in sample_ids:<br class=""> resp = client.get('api/db_default/v4/nts/samples/{}'.format(sid))<br class="">@@ -97,7 +97,9 @@ class JSONAPIDeleteTester(unittest.TestC<br class=""> for run_id in run_ids:<br class=""> resp = check_json(client,<br class=""> 'api/db_default/v4/nts/runs/{}'.format(run_id))<br class="">- sample_ids.append([s['id'] for s in resp['samples']])<br class="">+ import pprint<br class="">+ pprint.pprint(resp['tests'])<br class="">+ sample_ids.append([s['id'] for s in resp['tests']])<br class=""> self.assertNotEqual(len(sample_ids), 0)<br class=""><br class=""> resp = client.delete('api/db_default/v4/nts/machines/2')<br class="">@@ -130,7 +132,7 @@ Deleted machine 2<br class=""> """Check POST to /runs."""<br class=""> client = self.client<br class=""><br class="">- resp = client.get('api/db_default/v4/nts/runs/5')<br class="">+ resp = client.get('api/db_default/v4/nts/runs/999')<br class=""> self.assertEqual(resp.status_code, 404)<br class=""></blockquote><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">This was intended to check that the particular run we are going to post didn't exist before posting... according to the later asserts, we should end up with runs/5 not runs/999.</span></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>