<div dir="ltr">Sure.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 18, 2017 at 2:17 PM, Martell Malone <span dir="ltr"><<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Found it. Thank you<br>Rui I will combine the 3 patches and re-apply.<br><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 18, 2017 at 10:14 PM, Shoaib Meenai <span dir="ltr"><<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="m_-5806933763930600029m_2432989797194662638WordSection1">
<p class="MsoNormal">Sorry, it's LLVM_TEST_DEPENDS, not LLVM_TEST_TARGETS.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>><br>
<b>Date: </b>Tuesday, July 18, 2017 at 2:13 PM<br>
<b>To: </b>Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>><br>
<b>Cc: </b>Aleksey Shlyapnikov <<a href="mailto:alekseys@google.com" target="_blank">alekseys@google.com</a>>, Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>>, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>>, "<a href="mailto:reviews%2Bd29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">reviews+d29892+public+2a8588b<wbr>74c42dd09@reviews.llvm.org</a>" <<a href="mailto:reviews%2Bd29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">reviews+d29892+public+2a8588b<wbr>74c42dd09@reviews.llvm.org</a>>, Michael Spencer <<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>>,
Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>>, Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>>, Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>>, Bob Haarman <<a href="mailto:llvm@inglorion.net" target="_blank">llvm@inglorion.net</a>>, llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>, Martin Storsjö <<a href="mailto:martin@martin.st" target="_blank">martin@martin.st</a>>, Mateusz Mikuła <<a href="mailto:mati865@gmail.com" target="_blank">mati865@gmail.com</a>>,
Michał Górny <<a href="mailto:mgorny@gentoo.org" target="_blank">mgorny@gentoo.org</a>>, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span></p><div><div class="m_-5806933763930600029h5"><br>
<b>Subject: </b>Re: [PATCH] D29892: ar: add llvm-dlltool support<u></u><u></u></div></div><p></p>
</div><div><div class="m_-5806933763930600029h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Shoaib, <br>
<span style="font-size:9.5pt"><br>
LLVM_TEST_TARGETS is a variable specific to the cmake command of the build bot.<br>
I assume this is not something that is in the LLVM tree?<br>
Also strangely I never got an email from that bot, only the ubuntu one with the warnings as errors for the cast.<br>
Is this the only bot that complained about this?</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Tue, Jul 18, 2017 at 10:09 PM, Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal">Never mind, it's already been reverted. Keep that in mind for when it's reapplied though.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>><br>
<b>Date: </b>Tuesday, July 18, 2017 at 2:06 PM<br>
<b>To: </b>Aleksey Shlyapnikov <<a href="mailto:alekseys@google.com" target="_blank">alekseys@google.com</a>>, Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>><br>
<b>Cc: </b>Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>>, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>>, "<a href="mailto:reviews%2Bd29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">reviews+d29892+public+2a8588b<wbr>74c42dd09@reviews.llvm.org</a>"
<<a href="mailto:reviews%2Bd29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">reviews+d29892+public+2a8588b<wbr>74c42dd09@reviews.llvm.org</a>>, Michael Spencer <<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>>,
Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>>, Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>>, Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>>,
Bob Haarman <<a href="mailto:llvm@inglorion.net" target="_blank">llvm@inglorion.net</a>>, llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>, Martin Storsjö <<a href="mailto:martin@martin.st" target="_blank">martin@martin.st</a>>,
Mateusz Mikuła <<a href="mailto:mati865@gmail.com" target="_blank">mati865@gmail.com</a>>, Michał Górny <<a href="mailto:mgorny@gentoo.org" target="_blank">mgorny@gentoo.org</a>>, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><br>
<b>Subject: </b>Re: [PATCH] D29892: ar: add llvm-dlltool support<u></u><u></u></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div id="m_-5806933763930600029m_2432989797194662638m_8328732523255379591compose-container">
<div>
<div>
<p class="MsoNormal">That one sounds like a dependency issue. LLVM_TEST_TARGETS didn't include llvm-dlltool. Saleem is committing a fix.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Get
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__aka.ms_o0ukef&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=geKTIq-txmy1F962vr-0XHBgjbYyNRmoAjphGtrsJdk&s=taEAGlvZuII6SrKKg8lEwYVYY8z_vfv8nMVk60oEF6U&e=" target="_blank">
Outlook for iOS</a><u></u><u></u></p>
</div>
</div>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="m_-5806933763930600029m_2432989797194662638m_8328732523255379591divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Aleksey Shlyapnikov <<a href="mailto:alekseys@google.com" target="_blank">alekseys@google.com</a>><br>
<b>Sent:</b> Tuesday, July 18, 2017 2:02:18 PM<br>
<b>To:</b> Martell Malone<br>
<b>Cc:</b> Rui Ueyama; Peter Collingbourne; <a href="mailto:reviews%2BD29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">
reviews+D29892+public+2a8588b7<wbr>4c42dd09@reviews.llvm.org</a>; Michael Spencer; Saleem Abdulrasool; Ed Maste; Mehdi AMINI; Bob Haarman; llvm-commits; Martin Storsjö; Mateusz Mikuła; Michał Górny; Rafael Espíndola; Shoaib Meenai<br>
<b>Subject:</b> Re: [PATCH] D29892: ar: add llvm-dlltool support</span> <u></u><u></u></p>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal">That bot fails with<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<p class="MsoNormal">/mnt/b/sanitizer-buildbot3/san<wbr>itizer-x86_64-linux-fast/build<wbr>/llvm_build_asan/test/DllTool/<wbr>Output/coff-exports.def.<wbr>script: line 1: llvm-dlltool: command not found<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Jul 18, 2017 at 2:00 PM, Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">We ran into this before with the casts.<br>
It was previously a warning but someone made that warning an error on the build bots.<br>
Fixed in rL308360<u></u><u></u></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Jul 18, 2017 at 9:51 PM, Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Which error are you talking about? It doesn't seem like a gcc warning.
<u></u><u></u></p>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">E.g.
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_sanitizer-2Dx86-5F64-2Dlinux-2Dfast_builds_6544_steps_check-2Dllvm-2520asan_logs_stdio&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=NGjqRZfFnGHhitPAAInehRIIDSuEV9ReGnSn-KxKtG4&e=" target="_blank">
http://lab.llvm.org:8011/build<wbr>ers/sanitizer-x86_64-linux-<wbr>fast/builds/6544/steps/check-<wbr>llvm%20asan/logs/stdio</a><u></u><u></u></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Jul 18, 2017 at 1:36 PM, Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal">Thanks<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I already replied to the thread from the build bot. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">We have seen a similar cast gcc warning error before.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Easy fix in a follow up shortly.<u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue 18 Jul 2017 at 20:31, Aleksey Shlyapnikov via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">alekseyshl added a comment.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_sanitizer-2Dx86-5F64-2Dlinux-2Dfast_builds_6544&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=4nrKF6yz4qNp5hGTSnf7XoptRCd2baMDQChcqRhhMnc&e=" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/sanitizer-x86_64-linux-<wbr>fast/builds/6544</a>
is not happy about this patch.<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D29892&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=TXjerh85FUsBVRf-81mjdX_4sH1j0FW6YeG53BoBifw&e=" target="_blank">https://reviews.llvm.org/D2989<wbr>2</a><br>
<br>
<u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>