<div dir="ltr">llvm::count_if + make_range?<div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 18, 2017 at 2:30 PM, Hiroshi Yamauchi via Phabricator via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">yamauchi marked an inline comment as done.<br>
yamauchi added inline comments.<br>
<br>
<br>
================<br>
<span class="">Comment at: include/llvm/IR/Operator.h:477<br>
+    unsigned NumNonConstantIndices = 0;<br>
+    for (const_op_iterator I = idx_begin(), E = idx_end(); I != E; ++I) {<br>
+      if (!isa<ConstantInt>(I)) {<br>
----------------<br>
</span><span class="">sanjoy wrote:<br>
> You can use `llvm::count_if` here.<br>
</span>I used std::count_if instead as llvm::count_if seems to use the standard begin/end instead of the idx_begin/idx_end required here.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="https://reviews.llvm.org/D35499" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D35499</a><br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>