<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mv="http://macVmlSchemaUri" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Title" content="">
<meta name="Keywords" content="">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.msoIns
{mso-style-type:export-only;
mso-style-name:"";
text-decoration:underline;
color:teal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Sorry, it's LLVM_TEST_DEPENDS, not LLVM_TEST_TARGETS.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Martell Malone <martellmalone@gmail.com><br>
<b>Date: </b>Tuesday, July 18, 2017 at 2:13 PM<br>
<b>To: </b>Shoaib Meenai <smeenai@fb.com><br>
<b>Cc: </b>Aleksey Shlyapnikov <alekseys@google.com>, Rui Ueyama <ruiu@google.com>, Peter Collingbourne <peter@pcc.me.uk>, "reviews+d29892+public+2a8588b74c42dd09@reviews.llvm.org" <reviews+d29892+public+2a8588b74c42dd09@reviews.llvm.org>, Michael Spencer <bigcheesegs@gmail.com>,
Saleem Abdulrasool <compnerd@compnerd.org>, Ed Maste <emaste@freebsd.org>, Mehdi AMINI <joker.eph@gmail.com>, Bob Haarman <llvm@inglorion.net>, llvm-commits <llvm-commits@lists.llvm.org>, Martin Storsjö <martin@martin.st>, Mateusz Mikuła <mati865@gmail.com>,
Michał Górny <mgorny@gentoo.org>, Rafael Espíndola <rafael.espindola@gmail.com><br>
<b>Subject: </b>Re: [PATCH] D29892: ar: add llvm-dlltool support<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Shoaib, <br>
<span style="font-size:9.5pt"><br>
LLVM_TEST_TARGETS is a variable specific to the cmake command of the build bot.<br>
I assume this is not something that is in the LLVM tree?<br>
Also strangely I never got an email from that bot, only the ubuntu one with the warnings as errors for the cast.<br>
Is this the only bot that complained about this?</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Tue, Jul 18, 2017 at 10:09 PM, Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Never mind, it's already been reverted. Keep that in mind for when it's reapplied though.<o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>><br>
<b>Date: </b>Tuesday, July 18, 2017 at 2:06 PM<br>
<b>To: </b>Aleksey Shlyapnikov <<a href="mailto:alekseys@google.com" target="_blank">alekseys@google.com</a>>, Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>><br>
<b>Cc: </b>Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>>, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>>, "<a href="mailto:reviews%2Bd29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">reviews+d29892+public+2a8588b74c42dd09@reviews.llvm.org</a>"
<<a href="mailto:reviews%2Bd29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">reviews+d29892+public+2a8588b74c42dd09@reviews.llvm.org</a>>, Michael Spencer <<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>>,
Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>>, Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>>, Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>>,
Bob Haarman <<a href="mailto:llvm@inglorion.net" target="_blank">llvm@inglorion.net</a>>, llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>, Martin Storsjö <<a href="mailto:martin@martin.st" target="_blank">martin@martin.st</a>>,
Mateusz Mikuła <<a href="mailto:mati865@gmail.com" target="_blank">mati865@gmail.com</a>>, Michał Górny <<a href="mailto:mgorny@gentoo.org" target="_blank">mgorny@gentoo.org</a>>, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span><o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
<b>Subject: </b>Re: [PATCH] D29892: ar: add llvm-dlltool support<o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div id="m_8328732523255379591compose-container">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">That one sounds like a dependency issue. LLVM_TEST_TARGETS didn't include llvm-dlltool. Saleem is committing a fix.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Get
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__aka.ms_o0ukef&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=geKTIq-txmy1F962vr-0XHBgjbYyNRmoAjphGtrsJdk&s=taEAGlvZuII6SrKKg8lEwYVYY8z_vfv8nMVk60oEF6U&e=" target="_blank">
Outlook for iOS</a><o:p></o:p></p>
</div>
</div>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="m_8328732523255379591divRplyFwdMsg">
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span style="color:black">From:</span></b><span style="color:black"> Aleksey Shlyapnikov <<a href="mailto:alekseys@google.com" target="_blank">alekseys@google.com</a>><br>
<b>Sent:</b> Tuesday, July 18, 2017 2:02:18 PM<br>
<b>To:</b> Martell Malone<br>
<b>Cc:</b> Rui Ueyama; Peter Collingbourne; <a href="mailto:reviews%2BD29892%2Bpublic%2B2a8588b74c42dd09@reviews.llvm.org" target="_blank">
reviews+D29892+public+2a8588b74c42dd09@reviews.llvm.org</a>; Michael Spencer; Saleem Abdulrasool; Ed Maste; Mehdi AMINI; Bob Haarman; llvm-commits; Martin Storsjö; Mateusz Mikuła; Michał Górny; Rafael Espíndola; Shoaib Meenai<br>
<b>Subject:</b> Re: [PATCH] D29892: ar: add llvm-dlltool support</span> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">That bot fails with<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm_build_asan/test/DllTool/Output/coff-exports.def.script: line 1: llvm-dlltool: command not found<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On Tue, Jul 18, 2017 at 2:00 PM, Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">We ran into this before with the casts.<br>
It was previously a warning but someone made that warning an error on the build bots.<br>
Fixed in rL308360<o:p></o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On Tue, Jul 18, 2017 at 9:51 PM, Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Which error are you talking about? It doesn't seem like a gcc warning.
<o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">E.g.
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_sanitizer-2Dx86-5F64-2Dlinux-2Dfast_builds_6544_steps_check-2Dllvm-2520asan_logs_stdio&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=NGjqRZfFnGHhitPAAInehRIIDSuEV9ReGnSn-KxKtG4&e=" target="_blank">
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6544/steps/check-llvm%20asan/logs/stdio</a><o:p></o:p></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On Tue, Jul 18, 2017 at 1:36 PM, Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Thanks<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I already replied to the thread from the build bot. <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">We have seen a similar cast gcc warning error before.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Easy fix in a follow up shortly.<o:p></o:p></p>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On Tue 18 Jul 2017 at 20:31, Aleksey Shlyapnikov via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt">alekseyshl added a comment.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_sanitizer-2Dx86-5F64-2Dlinux-2Dfast_builds_6544&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=4nrKF6yz4qNp5hGTSnf7XoptRCd2baMDQChcqRhhMnc&e=" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6544</a>
is not happy about this patch.<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D29892&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=TXjerh85FUsBVRf-81mjdX_4sH1j0FW6YeG53BoBifw&e=" target="_blank">https://reviews.llvm.org/D29892</a><br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>