It's unlikely to be measurable in any sense<br><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 18, 2017, 9:56 AM Jakub Kuderski via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">kuhar added inline comments.<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:939<br>
+  assert(isa<BranchInst>(loopPreheader->getTerminator()));<br>
+  auto *OldBranch = cast<BranchInst>(loopPreheader->getTerminator());<br>
   EmitPreheaderBranchOnCondition(Cond, Val, NewExit, NewPH,<br>
----------------<br>
davide wrote:<br>
> instead of using isa<> + cast<> can you use `dyn_cast<>` maybe ?<br>
Wouldn't that be slower in release builds without assertions?<br>
<br>
<br>
<a href="https://reviews.llvm.org/D35528" rel="noreferrer" target="_blank">https://reviews.llvm.org/D35528</a><br>
<br>
<br>
<br>
</blockquote></div>