<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Vitaly,<div class=""><br class=""></div><div class="">I saw your fix, but I’m not sure that’s the correct way to go:</div><div class="">why is the buildbot configured with COMPILER_RT_DEBUG=True in the first place?</div><div class="">If tests only pass on optimized compiler runtime (which is also a bit confusing in itself),</div><div class="">wouldn’t it make more sense not ask for debug symbols in it on a buildbot?</div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 15, 2017, at 6:13 PM, Vitaly Buka <<a href="mailto:vitalybuka@google.com" class="">vitalybuka@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">FYI: I had to disable TSAN test because of this change <a href="https://reviews.llvm.org/rL308121" rel="noreferrer" target="_blank" class="gmail-cremed cremed" style="font-size:12.8px">https://reviews.llvm.org/<wbr class="">rL308121</a></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Jul 14, 2017 at 5:30 PM, George Karpenkov via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: george.karpenkov<br class="">
Date: Fri Jul 14 17:30:46 2017<br class="">
New Revision: 308072<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=308072&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=308072&view=rev</a><br class="">
Log:<br class="">
[compiler-rt] [CMake] Build compiler-rt with no optimizations if the flag says so<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D35400" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D35400</a><br class="">
<br class="">
Modified:<br class="">
compiler-rt/trunk/CMakeLists.<wbr class="">txt<br class="">
<br class="">
Modified: compiler-rt/trunk/CMakeLists.<wbr class="">txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=308072&r1=308071&r2=308072&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/compiler-rt/trunk/<wbr class="">CMakeLists.txt?rev=308072&r1=<wbr class="">308071&r2=308072&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- compiler-rt/trunk/CMakeLists.<wbr class="">txt (original)<br class="">
+++ compiler-rt/trunk/CMakeLists.<wbr class="">txt Fri Jul 14 17:30:46 2017<br class="">
@@ -172,10 +172,16 @@ endif()<br class="">
<br class="">
append_list_if(COMPILER_RT_<wbr class="">DEBUG -DSANITIZER_DEBUG=1 SANITIZER_COMMON_CFLAGS)<br class="">
<br class="">
-# Build with optimization, unless we're in debug mode. If we're using MSVC,<br class="">
+# If we're using MSVC,<br class="">
# always respect the optimization flags set by CMAKE_BUILD_TYPE instead.<br class="">
-if(NOT COMPILER_RT_DEBUG AND NOT MSVC)<br class="">
- list(APPEND SANITIZER_COMMON_CFLAGS -O3)<br class="">
+if (NOT MSVC)<br class="">
+<br class="">
+ # Build with optimization, unless we're in debug mode.<br class="">
+ if(COMPILER_RT_DEBUG)<br class="">
+ list(APPEND SANITIZER_COMMON_CFLAGS -O0)<br class="">
+ else()<br class="">
+ list(APPEND SANITIZER_COMMON_CFLAGS -O3)<br class="">
+ endif()<br class="">
endif()<br class="">
<br class="">
# Determine if we should restrict stack frame sizes.<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>