<div dir="ltr">They could - they're not catching ambiguous calls but rather providing as documentation in case someone wants to add the functions back (they shouldn't :). I can augment this with a comment if you'd like or we can come up with some other way?<div><br></div><div>Thanks!</div><div><br></div><div>-eric<br><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 10, 2017 at 11:59 AM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Could these function declarations be removed entirely? Looks like they aren't catching any ambiguous calls, etc, so probably?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 30, 2017 at 12:49 PM Eric Christopher via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br>
Date: Fri Jun 30 12:49:05 2017<br>
New Revision: 306864<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=306864&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=306864&view=rev</a><br>
Log:<br>
Make 0 argument getSubtargetImpl functions for the X86, AArch64, and PPC targets deleted so that no one is tempted to use them.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.h<br>
llvm/trunk/lib/Target/PowerPC/PPCTargetMachine.h<br>
llvm/trunk/lib/Target/X86/X86TargetMachine.h<br>
<br>
Modified: llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.h?rev=306864&r1=306863&r2=306864&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.h?rev=306864&r1=306863&r2=306864&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.h (original)<br>
+++ llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.h Fri Jun 30 12:49:05 2017<br>
@@ -36,6 +36,7 @@ public:<br>
<br>
~AArch64TargetMachine() override;<br>
const AArch64Subtarget *getSubtargetImpl(const Function &F) const override;<br>
+ const AArch64Subtarget *getSubtargetImpl() const = delete;<br>
<br>
// Pass Pipeline Configuration<br>
TargetPassConfig *createPassConfig(PassManagerBase &PM) override;<br>
<br>
Modified: llvm/trunk/lib/Target/PowerPC/PPCTargetMachine.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCTargetMachine.h?rev=306864&r1=306863&r2=306864&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCTargetMachine.h?rev=306864&r1=306863&r2=306864&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/PowerPC/PPCTargetMachine.h (original)<br>
+++ llvm/trunk/lib/Target/PowerPC/PPCTargetMachine.h Fri Jun 30 12:49:05 2017<br>
@@ -41,6 +41,7 @@ public:<br>
~PPCTargetMachine() override;<br>
<br>
const PPCSubtarget *getSubtargetImpl(const Function &F) const override;<br>
+ const PPCSubtarget *getSubtargetImpl() const = delete;<br>
<br>
// Pass Pipeline Configuration<br>
TargetPassConfig *createPassConfig(PassManagerBase &PM) override;<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86TargetMachine.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.h?rev=306864&r1=306863&r2=306864&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.h?rev=306864&r1=306863&r2=306864&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86TargetMachine.h (original)<br>
+++ llvm/trunk/lib/Target/X86/X86TargetMachine.h Fri Jun 30 12:49:05 2017<br>
@@ -40,6 +40,7 @@ public:<br>
~X86TargetMachine() override;<br>
<br>
const X86Subtarget *getSubtargetImpl(const Function &F) const override;<br>
+ const X86Subtarget *getSubtargetImpl() const = delete;<br>
<br>
TargetIRAnalysis getTargetIRAnalysis() override;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div></div></div>