<div dir="ltr">"unsigned int" appears 628 times in the entire lib directory. unsigned followed by something other than int/char/short appears 13074 times.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Mon, Jul 10, 2017 at 10:17 AM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'd have expected across all of LLVM that 'unsigned int' was more common, and to canonicalize in that direction rather than the other?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 7, 2017 at 10:16 PM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Fri Jul  7 22:16:14 2017<br>
New Revision: 307463<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=307463&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=307463&view=rev</a><br>
Log:<br>
[X86] Use 'unsigned' instead of 'unsigned int' for consistency in the X86 portion of Host.cpp.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Support/Host.<wbr>cpp<br>
<br>
Modified: llvm/trunk/lib/Support/Host.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Host.cpp?rev=307463&r1=307462&r2=307463&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Support/Host.cpp?rev=307463&<wbr>r1=307462&r2=307463&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Support/Host.<wbr>cpp (original)<br>
+++ llvm/trunk/lib/Support/Host.<wbr>cpp Fri Jul  7 22:16:14 2017<br>
@@ -526,8 +526,8 @@ static void detectX86FamilyModel(unsigne<br>
 }<br>
<br>
 static void<br>
-<wbr>getIntelProcessorTypeAndSubtyp<wbr>e(unsigned int Family, unsigned int Model,<br>
-                                unsigned int Brand_id, unsigned int Features,<br>
+<wbr>getIntelProcessorTypeAndSubtyp<wbr>e(unsigned Family, unsigned Model,<br>
+                                unsigned Brand_id, unsigned Features,<br>
                                 unsigned *Type, unsigned *Subtype) {<br>
   if (Brand_id != 0)<br>
     return;<br>
@@ -827,9 +827,9 @@ getIntelProcessorTypeAndSubtyp<wbr>e(unsigned<br>
   }<br>
 }<br>
<br>
-static void getAMDProcessorTypeAndSubtype(<wbr>unsigned int Family,<br>
-                                          unsigned int Model,<br>
-                                          unsigned int Features,<br>
+static void getAMDProcessorTypeAndSubtype(<wbr>unsigned Family,<br>
+                                          unsigned Model,<br>
+                                          unsigned Features,<br>
                                           unsigned *Type,<br>
                                           unsigned *Subtype) {<br>
   // FIXME: this poorly matches the generated SubtargetFeatureKV table.  There<br>
@@ -956,10 +956,10 @@ static void getAMDProcessorTypeAndSubtyp<br>
   }<br>
 }<br>
<br>
-static unsigned getAvailableFeatures(unsigned int ECX, unsigned int EDX,<br>
+static unsigned getAvailableFeatures(unsigned ECX, unsigned EDX,<br>
                                      unsigned MaxLeaf) {<br>
   unsigned Features = 0;<br>
-  unsigned int EAX, EBX;<br>
+  unsigned EAX, EBX;<br>
   Features |= (((EDX >> 23) & 1) << FEATURE_MMX);<br>
   Features |= (((EDX >> 25) & 1) << FEATURE_SSE);<br>
   Features |= (((EDX >> 26) & 1) << FEATURE_SSE2);<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
<br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>