<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;">> Reverted in r306996.</span><span style="color: rgb(33, 33, 33); font-size: 12pt;"></span><br>
</p>
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;"><br>
</span></p>
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;">Ed, thanks for reproduce !</span></p>
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;"><br>
</span></p>
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;">Rui, thanks for reverting. I found fix is one line trivial for this:</span></p>
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;"><br>
</span></p>
<div> if (Config->Shared) // This line should be added.<br>
</div>
<div> error(toString(File) + ": symbol " + S + " has undefined version " +</div>
<div> Verstr);<br>
</div>
<div><br>
</div>
<div>We had this chyeck in one of latest diffs during review but it was removed in final patch version,<br>
</div>
<div>I think we need to restore it.<br>
</div>
<div><br>
</div>
<div><a href="https://reviews.llvm.org/">reviews.llvm.org</a> is currently unavailable for everyone (it seems for about a day atm), </div>
<div>I'll update the patch with this change <span style="font-size: 12pt;">and trigger "needs review" again </span><span style="font-size: 12pt;">as soon as it be alive.</span></div>
<div><br>
</div>
<div>George.<br>
</div>
<div><br>
</div>
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;"><br>
</span></p>
</body>
</html>