<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 27, 2017 at 3:19 PM, Tim Shen <span dir="ltr"><<a href="mailto:timshen@google.com" target="_blank">timshen@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Clang sets lto::Config::UseNewPM. I suppose at somewheter in lib/LTO/LTOBackend.cpp we should look at UseNewPM and invoke <wbr>buildThinLTOPreLinkDefaultPipe<wbr>line, but I'm not sure where.</div></div></blockquote><div><br></div><div>The LTOBackend is used at link time (the ThinLTO backends), and already invokes buildThinLTODefaultPipeline. The passes in buildThinLTOPreLinkDefaultPipe<wbr>line are to be invoked during the compile (pre-link) phase, and hence I would expect either clang side or via something invoked to set up the compile passes from clang.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>I don't expect any more change on Clang side, though.</div></div><div class="gmail-HOEnZb"><div class="gmail-h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 27, 2017 at 3:01 PM Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I thought Tim landed something that used this? But maybe misremembering. I don't think I have a Clang patch outstanding... <a class="gmail-m_-4888132779938450059m_8239362083102044925GWVZpf gmail-m_-4888132779938450059m_8239362083102044925gW" id="gmail-m_-4888132779938450059m_8239362083102044925IloFPc-5" href="mailto:timshen@google.com" target="_blank">+Tim Shen</a> </div><br><div class="gmail_quote"></div><div class="gmail_quote"><div dir="ltr">On Tue, Jun 27, 2017 at 2:52 PM Teresa Johnson via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, May 25, 2017, 2:43 PM Chandler Carruth via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">chandlerc marked an inline comment as done.<br>
chandlerc added a comment.<br>
<br>
In <a href="https://reviews.llvm.org/D33540#764460" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D33540#764460</a>, @tejohnson wrote:<br>
<br>
> > I hoisted the ThinLTO stop point pre-link above the partial inliner and the RPO function attr inference. Partial inlining isn't going to make the code smaller and it seems better to just do that once post-link.<br>
><br>
> Added davidxl to comment on this change. It seems like doing some partial inlining during the pre-link for ThinLTO will have an effect on the importing. Also, it is pre-link (as well as post-link) in the old pass pipeline, so this would introduce an inconsistency between the pass pipelines. May be better to keep it in the same places, and evaluate the effect of removing it from the pre-link pass pipeline separately?<br>
<br>
<br>
Well, partial inliner isn't run at all yet. So my hope was it can get moved around later.<br>
<br>
I somewhat wanted to make the split line up with the simplification split that is already there in the pipeline. But if you feel strongly we need to keep these exactly the same, I can essentially copy the extra passes into the tail of the thinlto prelink stuff.<br>
<br>
<br>
<br>
================<br>
Comment at: lib/Passes/PassBuilder.cpp:708<br>
+ModulePassManager<br>
+PassBuilder::<wbr>buildThinLTOPreLinkDefaultPipe<wbr>line(OptimizationLevel Level,<br>
+ bool DebugLogging) {<br>
----------------<br>
tejohnson wrote:<br>
> I don't see this getting invoked.<br>
Yeah, the original patch had a change to Clang, but I wanted to get a submittable LLVM-focused version.<br></blockquote></div><div><br></div><div>Dehao just noticed that it still isn't be invoked, other than from the manual pipeline setup for testing. Do you still have your clang side changes around that you could submit? Or let me know if you prefer I add that.</div><div>Teresa</div><div><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I'll add support for parsing these pipelines much like we support parsing 'default<O2>' and such so that we have some coverage of stuff.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D33540" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D33540</a><br>
<br>
<br>
<br>
</blockquote></div></blockquote></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top:2px solid rgb(213,15,37)">Teresa Johnson |</td><td nowrap style="border-top:2px solid rgb(51,105,232)"> Software Engineer |</td><td nowrap style="border-top:2px solid rgb(0,153,57)"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top:2px solid rgb(238,178,17)"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>