<div dir="ltr">Good call - r305919<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Jun 21, 2017 at 12:04 AM Justin Bogner <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">David Blaikie via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> writes:<br>
> Author: dblaikie<br>
> Date: Mon Jun 12 15:09:53 2017<br>
> New Revision: 305226<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=305226&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=305226&view=rev</a><br>
> Log:<br>
> Remove unneeded conditionals - the code is already conditional on the<br>
> same condition<br>
><br>
> Modified:<br>
>     llvm/trunk/tools/llvm-stress/llvm-stress.cpp<br>
><br>
> Modified: llvm/trunk/tools/llvm-stress/llvm-stress.cpp<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-stress/llvm-stress.cpp?rev=305226&r1=305225&r2=305226&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-stress/llvm-stress.cpp?rev=305226&r1=305225&r2=305226&view=diff</a><br>
> ==============================================================================<br>
><br>
> --- llvm/trunk/tools/llvm-stress/llvm-stress.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-stress/llvm-stress.cpp Mon Jun 12 15:09:53 2017<br>
> @@ -405,17 +405,15 @@ struct ConstModifier: public Modifier {<br>
><br>
>      if (Ty->isIntegerTy()) {<br>
>        switch (Ran->Rand() % 7) {<br>
> -      case 0: if (Ty->isIntegerTy())<br>
> -                return PT->push_back(ConstantInt::get(Ty,<br>
> -                  APInt::getAllOnesValue(Ty->getPrimitiveSizeInBits())));<br>
> -              llvm_unreachable("Unexpected state");<br>
> -      case 1: if (Ty->isIntegerTy())<br>
> -                return PT->push_back(ConstantInt::get(Ty,<br>
> -                  APInt::getNullValue(Ty->getPrimitiveSizeInBits())));<br>
> -              llvm_unreachable("Unexpected state");<br>
> +      case 0:<br>
> +        return PT->push_back(ConstantInt::get(<br>
> +            Ty, APInt::getAllOnesValue(Ty->getPrimitiveSizeInBits())));<br>
> +      case 1:<br>
> +        return PT->push_back(ConstantInt::get(<br>
> +            Ty, APInt::getNullValue(Ty->getPrimitiveSizeInBits())));<br>
>        case 2: case 3: case 4: case 5:<br>
> -      case 6: if (Ty->isIntegerTy())<br>
> -                PT->push_back(ConstantInt::get(Ty, Ran->Rand()));<br>
> +      case 6:<br>
<br>
Might be worth clang-formatting while you're here. It's really odd that<br>
2-5 are all on a line together but 6 is on its own.<br>
<br>
> +        PT->push_back(ConstantInt::get(Ty, Ran->Rand()));<br>
>        }<br>
>      }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>