<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 15, 2017, at 3:57 PM, David Blaikie via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Jun 15, 2017 at 3:52 PM Matthias Braun <<a href="mailto:mbraun@apple.com" class="">mbraun@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="">
> On Jun 15, 2017, at 3:46 PM, Matthias Braun via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Indeed. Unfortunately I am running into problems now as ASSERT_TRUE appears to expand into something ending in "return;" in the error case which only works in void functions. Still looking around what the correct gtest idiom is.<br class="">
I moved the one problematic ASSERTs into a void function.<br class=""></blockquote><div class=""><br class="">Not sure how much that'd help though -it means the callers to the function will continue running after the ASSERT fails, right? Unless it's moved up to the top level TEST function.<br class=""></div></div></div></div></blockquote><div>Yep that is subtle, but happens to work fine in this case... It's basically one function call to perform the test and we abort that function in the error case which still makes sense.</div></div></body></html>