<div dir="ltr">Hi Zack,<div><br></div><div>this breaks cmake for me when I try to configure a build with NO targets:</div><div><span title="CMake Error" style="box-sizing:border-box;font-family:monospace;font-size:13px;white-space:pre-wrap;color:white;background-color:red">CMake Error at cmake/modules/LLVM-Config.cmake:31 (list):
</span><span style="color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap">  list sub-command REMOVE_ITEM requires two or more arguments.
Call Stack (most recent call first):
  cmake/modules/LLVM-Config.cmake:256 (is_llvm_target_library)
  cmake/modules/LLVM-Config.cmake:100 (llvm_map_components_to_libnames)
  cmake/modules/LLVM-Config.cmake:93 (explicit_llvm_config)
  cmake/modules/AddLLVM.cmake:714 (llvm_config)
  cmake/modules/AddLLVM.cmake:1025 (add_llvm_executable)
  unittests/CMakeLists.txt:5 (add_unittest)
  unittests/DebugInfo/CodeView/CMakeLists.txt:11 (add_llvm_unittest)</span><br></div><div><span style="color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap"><br></span></div>TestingSupport is configured with BUILDTREE_ONLY. This prevents it from being added to LLVM_LIBS. This seems intentional and mirrors what gtest_main is doing. The problem is that once you add TestingSupport as a link dependency our current cmake logic fails. It works for test_main, because it is never listed in LLVM_LINK_COMPONENTS and always added as part of add_unittest.<div><br></div><div>Doing the same for TestingSupport would fix the issue. </div><div><br></div><div>--Juergen</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 14, 2017 at 9:42 AM, Zachary Turner via Phabricator via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL305395: [gtest] Create a shared include directory for gtest utilities. (authored by zturner).<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D33059?vs=102340&id=102563#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D33059?vs=102340&id=102563#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D33059" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D33059</a><br>
<br>
Files:<br>
  llvm/trunk/include/llvm/<wbr>Testing/Support/Error.h<br>
  llvm/trunk/include/llvm/<wbr>Testing/Support/<wbr>SupportHelpers.h<br>
  llvm/trunk/lib/CMakeLists.txt<br>
  llvm/trunk/lib/LLVMBuild.txt<br>
  llvm/trunk/lib/Testing/<wbr>CMakeLists.txt<br>
  llvm/trunk/lib/Testing/<wbr>LLVMBuild.txt<br>
  llvm/trunk/lib/Testing/<wbr>Support/CMakeLists.txt<br>
  llvm/trunk/lib/Testing/<wbr>Support/Error.cpp<br>
  llvm/trunk/lib/Testing/<wbr>Support/LLVMBuild.txt<br>
  llvm/trunk/unittests/<wbr>DebugInfo/CodeView/CMakeLists.<wbr>txt<br>
  llvm/trunk/unittests/<wbr>DebugInfo/CodeView/<wbr>ErrorChecking.h<br>
  llvm/trunk/unittests/<wbr>DebugInfo/CodeView/<wbr>RandomAccessVisitorTest.cpp<br>
  llvm/trunk/unittests/<wbr>DebugInfo/CodeView/<wbr>TypeIndexDiscoveryTest.cpp<br>
  llvm/trunk/unittests/<wbr>DebugInfo/PDB/CMakeLists.txt<br>
  llvm/trunk/unittests/<wbr>DebugInfo/PDB/ErrorChecking.h<br>
  llvm/trunk/unittests/<wbr>DebugInfo/PDB/HashTableTest.<wbr>cpp<br>
  llvm/trunk/unittests/<wbr>DebugInfo/PDB/MSFBuilderTest.<wbr>cpp<br>
  llvm/trunk/unittests/<wbr>DebugInfo/PDB/<wbr>MappedBlockStreamTest.cpp<br>
  llvm/trunk/unittests/<wbr>DebugInfo/PDB/<wbr>StringTableBuilderTest.cpp<br>
  llvm/trunk/unittests/<wbr>DebugInfo/PDB/<wbr>TypeServerHandlerTest.cpp<br>
  llvm/trunk/unittests/Support/<wbr>BinaryStreamTest.cpp<br>
  llvm/trunk/unittests/Support/<wbr>CMakeLists.txt<br>
<br>
<br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>