<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Seems to work with <a href="https://reviews.llvm.org/D34217" class="">https://reviews.llvm.org/D34217</a><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 13, 2017, at 6:02 PM, Kostya Serebryany via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_extra"><br class="Apple-interchange-newline"><br class=""><div class="gmail_quote">On Tue, Jun 13, 2017 at 6:00 PM, Vedant Kumar via llvm-commits<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Jun 13, 2017, at 5:58 PM, Vedant Kumar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="m_5557048758374098088Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><blockquote type="cite" class=""><div class=""><br class="m_5557048758374098088Apple-interchange-newline">On Jun 13, 2017, at 5:53 PM, George Karpenkov <<a href="mailto:ekarpenkov@apple.com" target="_blank" class="">ekarpenkov@apple.com</a>> wrote:</div><br class="m_5557048758374098088Apple-interchange-newline"><div class=""><div style="word-wrap: break-word;" class="">I’m confused, all libfuzzer tests pass on my machine.<div class="">I suspect the issue is with older Darwin versions.</div></div></div></blockquote><div class=""><br class=""></div><div class="">This could be the case. The public Darwin bots may have older OSs and SDKs than the machine you're using.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word;" class=""><div class="">In that case, can we guard against older versions specifically, rather than disabling Darwin altogether?</div></div></div></blockquote><div class=""><br class=""></div><div class="">You could, but this would only make sense to me if there's at least one public Darwin bots on which this test passes, since otherwise the test would still not reliably provide coverage on Darwin.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word;" class=""><div class="">Also, why the error has only appeared now?<br class=""></div></div></div></blockquote><div class=""><br class=""></div>Are you referring to the "error in backend: Global variable '__sancov_gen_' has an invalid section specifier" issue? This has been an issue since at least June 3rd, but we've been marking the tests as unsupported on Darwin to suppress the failures.</div></div></blockquote><div class=""><br class=""></div></span>Er, excuse me, I meant '__sancov_counters'. (While we're on the topic, could the fix here be using '__sancov_cnts'?)</div></div></blockquote><div class="">probably. But I have no way to test it (other than by committing the change) </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div><div class="">vedant</div></font></span><div class=""><div class="h5"><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class="">vedant<br class=""><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word;" class=""><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Jun 13, 2017, at 4:10 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank" class="">kcc@google.com</a>> wrote:</div><br class="m_5557048758374098088Apple-interchange-newline"><div class=""><div dir="ltr" class="">also: r305335</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Jun 7, 2017 at 10:11 PM, George Karpenkov<span class="m_5557048758374098088Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:ekarpenkov@apple.com" target="_blank" class="">ekarpenkov@apple.<wbr class="">com</a>></span><span class="m_5557048758374098088Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class="">Weird though, my primary testing platform is a mac… maybe a different version? I’ll take a look.<div class="">Also section specifier did change between versions.<div class=""><div class="m_5557048758374098088h5"><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jun 7, 2017, at 9:29 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank" class="">kcc@google.com</a>> wrote:</div><br class="m_5557048758374098088m_-50908739262710170Apple-interchange-newline"><div class=""><div dir="ltr" class="">+ekarpenkov@<div class=""><br class=""></div><div class="">Will it help to use shorter name for this section on Mac? </div><div class=""><br class=""></div><div class="">--kcc </div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sat, Jun 3, 2017 at 6:56 PM, Vedant Kumar via llvm-commits<span class="m_5557048758374098088Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@<wbr class="">lists.llvm.org</a>></span><span class="m_5557048758374098088Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">Author: vedantk<br class="">Date: Sat Jun 3 20:56:44 2017<br class="">New Revision: 304673<br class=""><br class="">URL:<span class="m_5557048758374098088Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=304673&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/<wbr class="">llvm-project?rev=304673&view=<wbr class="">rev</a><br class="">Log:<br class="">Mark sancov test as unsupported on Darwin<br class=""><br class="">This test has been failing on all Darwin bots since it was introduced:<br class=""><a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/32111" rel="noreferrer" target="_blank" class="">http://lab.llvm.org:8080/green<wbr class="">/job/clang-stage1-configure-RA<wbr class="">_check/32111</a><br class=""><br class="">fatal error: error in backend: Global variable '__sancov_gen_' has an invalid section specifier '__DATA,__sancov_counters': mach-o section specifier requires a section whose length is between 1 and 16 characters.<br class="">Target: x86_64-apple-darwin15.6.0<br class=""><br class="">Modified:<br class=""> <span class="Apple-converted-space"> </span>compiler-rt/trunk/test/sanitiz<wbr class="">er_common/TestCases/sanitizer_<wbr class="">coverage_inline8bit_<a href="http://counter.cc/" target="_blank" class="">counter.cc</a><br class=""><br class="">Modified: compiler-rt/trunk/test/sanitiz<wbr class="">er_common/TestCases/sanitizer_<wbr class="">coverage_inline8bit_counter.cc<br class="">URL:<span class="m_5557048758374098088Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_inline8bit_counter.cc?rev=304673&r1=304672&r2=304673&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/<wbr class="">llvm-project/compiler-rt/<wbr class="">trunk/test/sanitizer_common/<wbr class="">TestCases/sanitizer_coverage_<wbr class="">inline8bit_counter.cc?rev=<wbr class="">304673&r1=304672&r2=304673&<wbr class="">view=diff</a><br class="">==============================<wbr class="">==============================<wbr class="">==================<br class="">--- compiler-rt/trunk/test/sanitiz<wbr class="">er_common/TestCases/sanitizer_<wbr class="">coverage_inline8bit_counter.cc (original)<br class="">+++ compiler-rt/trunk/test/sanitiz<wbr class="">er_common/TestCases/sanitizer_<wbr class="">coverage_inline8bit_counter.cc Sat Jun 3 20:56:44 2017<br class="">@@ -1,7 +1,7 @@<br class=""> // Tests -fsanitize-coverage=inline-8bi<wbr class="">t-counters<br class=""> //<br class=""> // REQUIRES: has_sancovcc,stable-runtime<br class="">-// UNSUPPORTED: i386-darwin<br class="">+// UNSUPPORTED: i386-darwin, x86_64-darwin<br class=""> //<br class=""> // RUN: %clangxx -O0 %s -fsanitize-coverage=inline-8bi<wbr class="">t-counters 2>&1<br class=""><br class=""><br class=""><br class="">______________________________<wbr class="">_________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class=""></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; float: none; display: inline !important;" class="">______________________________<wbr class="">_________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; float: none; display: inline !important;" class="">llvm-commits mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class="">llvm-commits@lists.llvm.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a></div></blockquote></div><br class=""></div></div></div><br class="">______________________________<wbr class="">_________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class=""><br class=""></blockquote></div><br class=""></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">llvm-commits mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></span></div></blockquote></div><br class=""></body></html>