<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 13, 2017 at 6:00 PM, Vedant Kumar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Jun 13, 2017, at 5:58 PM, Vedant Kumar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="m_5557048758374098088Apple-interchange-newline"><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><blockquote type="cite"><div><br class="m_5557048758374098088Apple-interchange-newline">On Jun 13, 2017, at 5:53 PM, George Karpenkov <<a href="mailto:ekarpenkov@apple.com" target="_blank">ekarpenkov@apple.com</a>> wrote:</div><br class="m_5557048758374098088Apple-interchange-newline"><div><div style="word-wrap:break-word">I’m confused, all libfuzzer tests pass on my machine.<div>I suspect the issue is with older Darwin versions.</div></div></div></blockquote><div><br></div><div>This could be the case. The public Darwin bots may have older OSs and SDKs than the machine you're using.</div><br><blockquote type="cite"><div><div style="word-wrap:break-word"><div>In that case, can we guard against older versions specifically, rather than disabling Darwin altogether?</div></div></div></blockquote><div><br></div><div>You could, but this would only make sense to me if there's at least one public Darwin bots on which this test passes, since otherwise the test would still not reliably provide coverage on Darwin.</div><br><blockquote type="cite"><div><div style="word-wrap:break-word"><div>Also, why the error has only appeared now?<br></div></div></div></blockquote><div><br></div>Are you referring to the "error in backend: Global variable '__sancov_gen_' has an invalid section specifier" issue? This has been an issue since at least June 3rd, but we've been marking the tests as unsupported on Darwin to suppress the failures.</div></div></blockquote><div><br></div></span>Er, excuse me, I meant '__sancov_counters'. (While we're on the topic, could the fix here be using '__sancov_cnts'?)</div></div></blockquote><div>probably. But I have no way to test it (other than by committing the change) </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span class="HOEnZb"><font color="#888888"><div><br></div><div>vedant</div></font></span><div><div class="h5"><div><br><blockquote type="cite"><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">vedant<br><div><br></div><br><blockquote type="cite"><div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>On Jun 13, 2017, at 4:10 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:</div><br class="m_5557048758374098088Apple-interchange-newline"><div><div dir="ltr">also: r305335</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 7, 2017 at 10:11 PM, George Karpenkov<span class="m_5557048758374098088Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:ekarpenkov@apple.com" target="_blank">ekarpenkov@apple.<wbr>com</a>></span><span class="m_5557048758374098088Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word">Weird though, my primary testing platform is a mac… maybe a different version? I’ll take a look.<div>Also section specifier did change between versions.<div><div class="m_5557048758374098088h5"><br><div><blockquote type="cite"><div>On Jun 7, 2017, at 9:29 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:</div><br class="m_5557048758374098088m_-50908739262710170Apple-interchange-newline"><div><div dir="ltr">+ekarpenkov@<div><br></div><div>Will it help to use shorter name for this section on Mac? </div><div><br></div><div>--kcc </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jun 3, 2017 at 6:56 PM, Vedant Kumar via llvm-commits<span class="m_5557048758374098088Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@<wbr>lists.llvm.org</a>></span><span class="m_5557048758374098088Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: vedantk<br>Date: Sat Jun  3 20:56:44 2017<br>New Revision: 304673<br><br>URL:<span class="m_5557048758374098088Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=304673&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project?rev=304673&view=<wbr>rev</a><br>Log:<br>Mark sancov test as unsupported on Darwin<br><br>This test has been failing on all Darwin bots since it was introduced:<br><a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/32111" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green<wbr>/job/clang-stage1-configure-RA<wbr>_check/32111</a><br><br>fatal error: error in backend: Global variable '__sancov_gen_' has an invalid section specifier '__DATA,__sancov_counters': mach-o section specifier requires a section whose length is between 1 and 16 characters.<br>Target: x86_64-apple-darwin15.6.0<br><br>Modified:<br>    compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_<a href="http://counter.cc/" target="_blank">counter.cc</a><br><br>Modified: compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_counter.cc<br>URL:<span class="m_5557048758374098088Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_inline8bit_counter.cc?rev=304673&r1=304672&r2=304673&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project/compiler-rt/<wbr>trunk/test/sanitizer_common/<wbr>TestCases/sanitizer_coverage_<wbr>inline8bit_counter.cc?rev=<wbr>304673&r1=304672&r2=304673&<wbr>view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_counter.cc (original)<br>+++ compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_counter.cc Sat Jun  3 20:56:44 2017<br>@@ -1,7 +1,7 @@<br> // Tests -fsanitize-coverage=inline-8bi<wbr>t-counters<br> //<br> // REQUIRES: has_sancovcc,stable-runtime<br>-// UNSUPPORTED: i386-darwin<br>+// UNSUPPORTED: i386-darwin, x86_64-darwin<br> //<br> // RUN: %clangxx -O0 %s -fsanitize-coverage=inline-8bi<wbr>t-counters 2>&1<br><br><br><br>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br></blockquote></div><br></div></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div></blockquote></div><br></div></div></div></blockquote></div><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">______________________________<wbr>_________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">llvm-commits mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:llvm-commits@lists.llvm.org" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">llvm-commits@lists.llvm.org</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div></div><br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>