<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 13, 2017 at 5:53 PM, George Karpenkov <span dir="ltr"><<a href="mailto:ekarpenkov@apple.com" target="_blank">ekarpenkov@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word">I’m confused, all libfuzzer tests pass on my machine.</div></blockquote><div><br></div><div>As of now, there is</div><div>if (NOT APPLE AND NOT MSVC) </div><div> add_subdirectory(inline-8bit-counters) </div><div>endif() </div><div>in lib/Fuzzer/test/CMakeLists.txt</div><div><br></div><div>If you remove the if(), will these tests still pass? </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div>I suspect the issue is with older Darwin versions.</div><div>In that case, can we guard against older versions specifically, rather than disabling Darwin altogether?</div></div></blockquote><div><br></div><div>Can we stop using old darwin on the bots? </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div>Also, why the error has only appeared now?</div></div></blockquote><div><br></div><div>This is a new experimental functionality (faster coverage instrumentation; not feature-complete yet). </div><div>I've added -fsanitize-coverage=inline-8bit-counters ~ 10 days ago and a related test for libFuzzer today. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><div><div class="gmail-h5"><br><div><blockquote type="cite"><div>On Jun 13, 2017, at 4:10 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:</div><br class="gmail-m_-2838874521656692043Apple-interchange-newline"><div><div dir="ltr">also: r305335</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 7, 2017 at 10:11 PM, George Karpenkov <span dir="ltr"><<a href="mailto:ekarpenkov@apple.com" target="_blank">ekarpenkov@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word">Weird though, my primary testing platform is a mac… maybe a different version? I’ll take a look.<div>Also section specifier did change between versions.<div><div class="gmail-m_-2838874521656692043h5"><br><div><blockquote type="cite"><div>On Jun 7, 2017, at 9:29 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:</div><br class="gmail-m_-2838874521656692043m_-50908739262710170Apple-interchange-newline"><div><div dir="ltr">+ekarpenkov@<div><br></div><div>Will it help to use shorter name for this section on Mac? </div><div><br></div><div>--kcc </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jun 3, 2017 at 6:56 PM, Vedant Kumar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: vedantk<br>
Date: Sat Jun 3 20:56:44 2017<br>
New Revision: 304673<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304673&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=304673&view=rev</a><br>
Log:<br>
Mark sancov test as unsupported on Darwin<br>
<br>
This test has been failing on all Darwin bots since it was introduced:<br>
<a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/32111" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green<wbr>/job/clang-stage1-configure-RA<wbr>_check/32111</a><br>
<br>
fatal error: error in backend: Global variable '__sancov_gen_' has an invalid section specifier '__DATA,__sancov_counters': mach-o section specifier requires a section whose length is between 1 and 16 characters.<br>
Target: x86_64-apple-darwin15.6.0<br>
<br>
Modified:<br>
compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_<a href="http://counter.cc/" target="_blank">counter.cc</a><br>
<br>
Modified: compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_counter.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_inline8bit_counter.cc?rev=304673&r1=304672&r2=304673&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/test/s<wbr>anitizer_common/TestCases/sani<wbr>tizer_coverage_inline8bit_coun<wbr>ter.cc?rev=304673&r1=304672&<wbr>r2=304673&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_counter.cc (original)<br>
+++ compiler-rt/trunk/test/sanitiz<wbr>er_common/TestCases/sanitizer_<wbr>coverage_inline8bit_counter.cc Sat Jun 3 20:56:44 2017<br>
@@ -1,7 +1,7 @@<br>
// Tests -fsanitize-coverage=inline-8bi<wbr>t-counters<br>
//<br>
// REQUIRES: has_sancovcc,stable-runtime<br>
-// UNSUPPORTED: i386-darwin<br>
+// UNSUPPORTED: i386-darwin, x86_64-darwin<br>
//<br>
// RUN: %clangxx -O0 %s -fsanitize-coverage=inline-8bi<wbr>t-counters 2>&1<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div>