<div dir="ltr">Why can't ReportError be noreturn?</div><br><div class="gmail_quote"><div dir="ltr">On Sat, Jun 10, 2017 at 12:50 AM Galina Kistanova via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: gkistanova<br>
Date: Sat Jun 10 02:50:14 2017<br>
New Revision: 305143<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=305143&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=305143&view=rev</a><br>
Log:<br>
Added llvm_unreachable as ReportError cannot be specified as noreturn.<br>
<br>
Modified:<br>
    llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp?rev=305143&r1=305142&r2=305143&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp?rev=305143&r1=305142&r2=305143&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp Sat Jun 10 02:50:14 2017<br>
@@ -585,6 +585,7 @@ void DWARFDebugFrame::parse(DataExtracto<br>
           switch (AugmentationString[i]) {<br>
             default:<br>
               ReportError("Unknown augmentation character in entry at %lx");<br>
+              llvm_unreachable("ReportError should not return.");<br>
             case 'L':<br>
               LSDAPointerEncoding = Data.getU8(&Offset);<br>
               break;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>