<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 8, 2017 at 8:12 PM Chandler Carruth via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">chandlerc added a comment.<br>
<br>
I'm pretty happy to start simple with a flag and go from there.<br>
<br>
<br>
<br>
================<br>
Comment at: lib/Support/Signals.cpp:39-42<br>
+static cl::opt<bool><br>
+    DisableSymbolication("disable-symbolication",<br>
+                         cl::desc("Disable symbolizing crash backtraces."),<br>
+                         cl::init(false), cl::Hidden);<br>
----------------<br>
Especially because this is initialized to false initially, I think it'll be fine even if we crash in weird places.  </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
================<br>
Comment at: tools/bugpoint/ToolRunner.cpp:66-67<br>
   const StringRef *Redirects[3] = {&StdInFile, &StdOutFile, &StdErrFile};<br>
-  return sys::ExecuteAndWait(ProgramPath, Args, nullptr, Redirects, NumSeconds,<br>
+  std::vector<const char*> Env = {"LLVM_DISABLE_SYMBOLICATION"};<br>
+  return sys::ExecuteAndWait(ProgramPath, Args, Env.data(), Redirects, NumSeconds,<br>
                              MemoryLimit, ErrMsg);<br>
----------------<br>
I assume this was just an experiment?<br>
<br>
<br>
================<br>
Comment at: tools/bugpoint/ToolRunner.cpp:85-88<br>
+  std::vector<const char*> Env = {"LLVM_DISABLE_SYMBOLICATION"};<br>
+<br>
   // Run the program remotely with the remote client<br>
+  int ReturnCode = sys::ExecuteAndWait(RemoteClientPath, Args, Env.data(),<br>
----------------<br>
same...<br></blockquote><div><br>Ah, yeah - thanks for catching those!<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<a href="https://reviews.llvm.org/D33804" rel="noreferrer" target="_blank">https://reviews.llvm.org/D33804</a><br>
<br>
<br>
<br>
</blockquote></div></div>