<div dir="ltr">Thank you.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 7, 2017 at 2:11 PM, Vedant Kumar <span dir="ltr"><<a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span></span><span>Done in </span><span>r30494{3, 4}.</span><span class="HOEnZb"><font color="#888888"><div><br></div><div>vedant</div></font></span><div><div class="h5"><div><br><div><blockquote type="cite"><div>On Jun 7, 2017, at 2:08 PM, Vedant Kumar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="m_5976339291950264576Apple-interchange-newline"><div><div style="word-wrap:break-word">Thanks for pointing this out. I'll revert this and mark the test as unsupported on darwin.<div><br></div><div>vedant</div><div><br><div><blockquote type="cite"><div>On Jun 7, 2017, at 2:02 PM, Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>> wrote:</div><br class="m_5976339291950264576Apple-interchange-newline"><div><div dir="ltr">Actually it depends on return value.<div>Test is for char* version of function. It will probably fail for int version.</div><div><br></div><div>Probably better just:</div><div>// UNSUPPORTED: darwin<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 7, 2017 at 1:43 PM, Vedant Kumar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vedantk<br>
Date: Wed Jun 7 15:43:15 2017<br>
New Revision: 304941<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304941&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=304941&view=rev</a><br>
Log:<br>
Fix tsan test for Darwin. NFCI.<br>
<br>
On Darwin, strerror_r returns an int, not a char*. I don't think this<br>
test really depends on what strerror_r returns, so I've used something<br>
else in place of the result of the call to strerror_r.<br>
<br>
Modified:<br>
compiler-rt/trunk/test/tsan/st<wbr>rerror_r.cc<br>
<br>
Modified: compiler-rt/trunk/test/tsan/st<wbr>rerror_r.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/strerror_r.cc?rev=304941&r1=304940&r2=304941&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/test/<wbr>tsan/strerror_r.cc?rev=304941&<wbr>r1=304940&r2=304941&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/test/tsan/st<wbr>rerror_r.cc (original)<br>
+++ compiler-rt/trunk/test/tsan/st<wbr>rerror_r.cc Wed Jun 7 15:43:15 2017<br>
@@ -10,7 +10,8 @@<br>
char buffer[1000];<br>
<br>
void *Thread(void *p) {<br>
- return strerror_r(TEST_ERROR, buffer, sizeof(buffer));<br>
+ (void)strerror_r(TEST_ERROR, buffer, sizeof(buffer));<br>
+ return p;<br>
}<br>
<br>
int main() {<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></blockquote></div><br></div></div>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div>