<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="" applecontenteditable="true"><span class=""></span><span class="">Done in </span><span class="">r30494{3, 4}.</span><div class=""><br class=""></div><div class="">vedant</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 7, 2017, at 2:08 PM, Vedant Kumar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="" applecontenteditable="true">Thanks for pointing this out. I'll revert this and mark the test as unsupported on darwin.<div class=""><br class=""></div><div class="">vedant</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jun 7, 2017, at 2:02 PM, Vitaly Buka <<a href="mailto:vitalybuka@google.com" class="">vitalybuka@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Actually it depends on return value.<div class="">Test is for char* version of function. It will probably fail for int version.</div><div class=""><br class=""></div><div class="">Probably better just:</div><div class="">// UNSUPPORTED: darwin<br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Jun 7, 2017 at 1:43 PM, Vedant Kumar via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vedantk<br class="">
Date: Wed Jun 7 15:43:15 2017<br class="">
New Revision: 304941<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304941&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=304941&view=rev</a><br class="">
Log:<br class="">
Fix tsan test for Darwin. NFCI.<br class="">
<br class="">
On Darwin, strerror_r returns an int, not a char*. I don't think this<br class="">
test really depends on what strerror_r returns, so I've used something<br class="">
else in place of the result of the call to strerror_r.<br class="">
<br class="">
Modified:<br class="">
compiler-rt/trunk/test/tsan/<wbr class="">strerror_r.cc<br class="">
<br class="">
Modified: compiler-rt/trunk/test/tsan/<wbr class="">strerror_r.cc<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/strerror_r.cc?rev=304941&r1=304940&r2=304941&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/compiler-rt/trunk/<wbr class="">test/tsan/strerror_r.cc?rev=<wbr class="">304941&r1=304940&r2=304941&<wbr class="">view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- compiler-rt/trunk/test/tsan/<wbr class="">strerror_r.cc (original)<br class="">
+++ compiler-rt/trunk/test/tsan/<wbr class="">strerror_r.cc Wed Jun 7 15:43:15 2017<br class="">
@@ -10,7 +10,8 @@<br class="">
char buffer[1000];<br class="">
<br class="">
void *Thread(void *p) {<br class="">
- return strerror_r(TEST_ERROR, buffer, sizeof(buffer));<br class="">
+ (void)strerror_r(TEST_ERROR, buffer, sizeof(buffer));<br class="">
+ return p;<br class="">
}<br class="">
<br class="">
int main() {<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>