<div dir="ltr">Sorry, didn't realize that the other bots didn't build these files. Fixed in r304843.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 6, 2017 at 2:28 PM Evgenii Stepanov <<a href="mailto:eugeni.stepanov@gmail.com">eugeni.stepanov@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
one of your changes in the range [304787, 304790] broke compilation on<br>
the sanitizer-windows bot:<br>
<br>
C:\b\slave\sanitizer-windows\build\bin\clang-cl.exe   /nologo<br>
-DLLVM_BUILD_GLOBAL_ISEL -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE<br>
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE<br>
-D_CRT_SECURE_NO_WARNINGS -D_DEBUG_POINTER_IMPL=""<br>
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_SCL_SECURE_NO_DEPRECATE<br>
-D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS<br>
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Fuzzer<br>
-IC:\b\slave\sanitizer-windows\llvm\lib\Fuzzer -Iinclude<br>
-IC:\b\slave\sanitizer-windows\llvm\include /DWIN32 /D_WINDOWS /W3<br>
/Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro -Wall -W<br>
-Wno-unused-parameter -Wwrite-strings -Wcast-qual<br>
-Wmissing-field-initializers -Wcovered-switch-default<br>
-Wdelete-non-virtual-dtor -Wstring-conversion /Oy- /Z7<br>
-fsanitize=address<br>
-fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp<br>
-fno-sanitize-coverage=trace-pc-guard,edge,trace-cmp,indirect-calls,8bit-counters<br>
-Werror /MD /O2 /Ob2   -UNDEBUG /showIncludes<br>
/Folib\Fuzzer\CMakeFiles\LLVMFuzzerNoMainObjects.dir\FuzzerExtFunctionsDlsymWin.cpp.obj<br>
/Fdlib\Fuzzer\CMakeFiles\LLVMFuzzerNoMainObjects.dir\ -c<br>
C:\b\slave\sanitizer-windows\llvm\lib\Fuzzer\FuzzerExtFunctionsDlsymWin.cpp<br>
In file included from<br>
C:\b\slave\sanitizer-windows\llvm\lib\Fuzzer\FuzzerExtFunctionsDlsymWin.cpp:16:<br>
C:\Program Files (x86)\Windows<br>
Kits\10\include\10.0.14393.0\um\Psapi.h(90,1):  error: unknown type<br>
name 'BOOL'<br>
<br>
<a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/12494/steps/build%20LLVMFuzzer/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/12494/steps/build%20LLVMFuzzer/logs/stdio</a><br>
<br>
On Tue, Jun 6, 2017 at 5:31 AM, Chandler Carruth via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: chandlerc<br>
> Date: Tue Jun  6 07:31:55 2017<br>
> New Revision: 304790<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304790&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=304790&view=rev</a><br>
> Log:<br>
> Fix several more missing headers, all of these were hidden by "lucky"<br>
> include ordering.<br>
><br>
> Modified:<br>
>     llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h<br>
>     llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h<br>
>     llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h<br>
><br>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h?rev=304790&r1=304789&r2=304790&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h?rev=304790&r1=304789&r2=304790&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h (original)<br>
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h Tue Jun  6 07:31:55 2017<br>
> @@ -11,6 +11,7 @@<br>
>  #define LLVM_DEBUGINFO_PDB_DIA_DIAENUMDEBUGSTREAMS_H<br>
><br>
>  #include "DIASupport.h"<br>
> +#include "llvm/DebugInfo/PDB/IPDBDataStream.h"<br>
>  #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"<br>
><br>
>  namespace llvm {<br>
><br>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h?rev=304790&r1=304789&r2=304790&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h?rev=304790&r1=304789&r2=304790&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h (original)<br>
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h Tue Jun  6 07:31:55 2017<br>
> @@ -12,6 +12,7 @@<br>
><br>
>  #include "DIASupport.h"<br>
>  #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"<br>
> +#include "llvm/DebugInfo/PDB/IPDBLineNumber.h"<br>
><br>
>  namespace llvm {<br>
>  namespace pdb {<br>
><br>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h?rev=304790&r1=304789&r2=304790&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h?rev=304790&r1=304789&r2=304790&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h (original)<br>
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h Tue Jun  6 07:31:55 2017<br>
> @@ -12,6 +12,7 @@<br>
><br>
>  #include "DIASupport.h"<br>
>  #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"<br>
> +#include "llvm/DebugInfo/PDB/IPDBSourceFile.h"<br>
><br>
>  namespace llvm {<br>
>  namespace pdb {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>